Re: [calligra/calligra/2.9] /: Fix warnings/bugs noted by André Wöbbeking

2015-01-10 Thread Friedrich W. H. Kossebau
Hi, Am Freitag, 9. Januar 2015, 09:06:42 schrieb Boudewijn Rempt: > Git commit 3eacc21365ce8502a65a676bc56a6623f60bd7f1 by Boudewijn Rempt. > I didn't touch: > > calligra/3rdparty/kdchart/src/KDChartPieDiagram.cpp:583 > calligra/filters/sheets/applixspread/applixspreadimport.cc:879 > calligra/fil

Re: Review Request 121837: Add more documentation about use of MSOScheme

2015-01-10 Thread Jos van den Oever
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121837/ --- (Updated Jan. 10, 2015, 7:54 p.m.) Status -- This change has been ma

Re: Review Request 121837: Add more documentation about use of MSOScheme

2015-01-10 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121837/#review73681 --- Ship it! Definitely an improvement, thanks. filters/libmso/

Re: How to generate mso.jar (Re: Calligra licensing and copyright bits)

2015-01-10 Thread Friedrich W. H. Kossebau
Am Sonntag, 4. Januar 2015, 20:24:26 schrieb Jos van den Oever: > On 01/04/2015 07:43 PM, Friedrich W. H. Kossebau wrote: > > thanks for the quick and workloaden reaction, great :) > > It was some needed work. Happy to help. > > > Am Sonntag, 4. Januar 2015, 17:06:26 schrieb Jos van den Oever: >

Re: Review Request 121830: Remove foreign elements before validating.

2015-01-10 Thread Jos van den Oever
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121830/ --- (Updated Jan. 10, 2015, 7:03 p.m.) Status -- This change has been ma

Re: Review Request 121830: Remove foreign elements before validating.

2015-01-10 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121830/#review73676 --- Ship it! Works for me for what I tested. And removeForeign.xs

Review Request 121968: Krita: Refactoring of how KisActions are enabled and disabled

2015-01-10 Thread Scott Petrovic
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121968/ --- Review request for Calligra. Repository: calligra Description ---

Re: How to deal with typo "2" instead of "2.1" for "GNU Lesser General Public" in headers?

2015-01-10 Thread Friedrich W. H. Kossebau
Am Sonntag, 4. Januar 2015, 19:03:44 schrieb Friedrich W. H. Kossebau: > Happy New Year, all, > > though I just made a not too happy discovery: > there are quite some files in the Calligra codebase which have a somehow > broken license header which names the "GNU Lesser General Public" in > "versi

Re: Review Request 120935: Add 'Value' property to report items which can contain static data if not bound to a field

2015-01-10 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120935/ --- (Updated Jan. 10, 2015, 3:57 p.m.) Status -- This change has been ma

Re: beta 2

2015-01-10 Thread Adam Pigg
I got my change in too! On Sat Jan 10 2015 at 13:21:58 Jaroslaw Staniek wrote: > Done! > > On 10 January 2015 at 00:41, Jaroslaw Staniek wrote: > > On 3 January 2015 at 20:26, Boudewijn Rempt wrote: > >> I saw that Jaroslaw managed to push his big thing, and so did I, today > -- > >> there's s

Re: beta 2

2015-01-10 Thread Jaroslaw Staniek
Done! On 10 January 2015 at 00:41, Jaroslaw Staniek wrote: > On 3 January 2015 at 20:26, Boudewijn Rempt wrote: >> I saw that Jaroslaw managed to push his big thing, and so did I, today -- >> there's still plenty bugs I need to fix, but I'm now fine with a beta2 next >> week. > > @Cyrille @Boude

Re: Review Request 121938: Properly merge record navigator with horizontal scrollbar

2015-01-10 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121938/ --- (Updated Jan. 10, 2015, 11:11 a.m.) Status -- This change has been m

Re: Review Request 120935: Add 'Value' property to report items which can contain static data if not bound to a field

2015-01-10 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120935/#review73658 --- Ship it! Good Job! - Jarosław Staniek On Jan. 4, 2015, 10:

Re: Review Request 121938: Properly merge record navigator with horizontal scrollbar

2015-01-10 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121938/#review73656 --- Ship it! Looks good, and a net reduction in code! - Adam Pig