----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120935/#review73658 -----------------------------------------------------------
Ship it! Good Job! - Jarosław Staniek On Jan. 4, 2015, 10:41 p.m., Adam Pigg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120935/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2015, 10:41 p.m.) > > > Review request for Calligra, Friedrich W. H. Kossebau and Jarosław Staniek. > > > Repository: calligra > > > Description > ------- > > Added a new property to the following report items: > check > field > text > barcode > Renamed image property 'Static Image' to Value but left saving/loading the > same for compatibility. > > Added a method to KoReportDesignerItemRectBase to store a string used for > rendering data in the report designer. > Report designer shows the static data if used > > Includes a bug fix in KRSize which meant recursion was possible > Includes a small fix to Text item which caused an infinite loop. > > > Diffs > ----- > > libs/koreport/items/field/KoReportItemField.cpp e2ce309 > libs/koreport/items/image/KoReportDesignerItemImage.cpp af4925f > libs/koreport/items/image/KoReportItemImage.cpp 286225f > libs/koreport/items/text/KoReportDesignerItemText.h 6822ee8 > libs/koreport/items/text/KoReportDesignerItemText.cpp f656dc3 > libs/koreport/items/text/KoReportItemText.h d843aa8 > libs/koreport/items/text/KoReportItemText.cpp d6296bd > libs/koreport/wrtembed/KoReportDesignerItemBase.h 5d43131 > libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp a542e87 > plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp 5d38862 > plugins/reporting/barcode/KoReportItemBarcode.h 0189f96 > plugins/reporting/barcode/KoReportItemBarcode.cpp d7d9278 > libs/koreport/items/check/KoReportDesignerItemCheck.cpp 01b5f1c > libs/koreport/items/check/KoReportItemCheck.h fafe2c4 > libs/koreport/items/check/KoReportItemCheck.cpp 224a744 > libs/koreport/items/field/KoReportDesignerItemField.cpp 6910224 > libs/koreport/items/field/KoReportItemField.h 26080f3 > libs/koreport/common/krsize.h cc319c0 > libs/koreport/common/krsize.cpp f8c0d7b > > Diff: https://git.reviewboard.kde.org/r/120935/diff/ > > > Testing > ------- > > Loading/saving each item type > Testing each type with: > value set, value not set and data source set, data source set and value set > > Items display correctly in designer > > > Thanks, > > Adam Pigg > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
