Re: Behaviour of KoServiceLocator

2014-09-14 Thread Jaroslaw Staniek
On 10 September 2014 23:05, Adam Pigg wrote: > Ive tested the patch in relation to BUG: 338737, where the migratemanager is > unable to load the postgresql driver, and this fixed it. Thanks, You probably mean https://bugs.kde.org/show_bug.cgi?id=338735 ... Since it's urgent fix for a regression i

Review Request 120209: Remove unused Find*.cmake scripts

2014-09-14 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120209/ --- Review request for Calligra, Cyrille Berger Skott, Camilla Boemann, Stuart

Re: Review Request 119183: A HSV color slider docker.

2014-09-14 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119183/#review66476 --- There are a few minor issues: 1) Coding style, which can be f

Re: Review Request 120191: Allow to have more than one zoom widget

2014-09-14 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120191/#review66463 --- Ship it! The patch looks fine to me. Both codewise and how it

Re: Review Request 120033: Multiple map elements render in reports.

2014-09-14 Thread Radosław Wicik
> On Wrz 7, 2014, 1:20 rano, Wojciech Kosowicz wrote: > > this patch does not build neither on master nor calligra/2.8 Could you send me the error message? I have no build errors. - Radosław --- This is an automatically generated e-mai

Re: Review Request 119183: A HSV color slider docker.

2014-09-14 Thread Dmitry Kazakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119183/#review66460 --- There is some weirdness when the sliders has extreem values: