Re: Review Request 119136: Fix issue with resolving version of plugins (at least) on Linux

2014-07-14 Thread Jarosław Staniek
> On July 11, 2014, 9:53 p.m., Adam Pigg wrote: > > Ship It! Thanks, I will just need more time to integrate with Boud's changes for Calligra plugins. - Jarosław --- This is an automatically generated e-mail. To reply, visit: https://g

Re: Review Request 119245: Use a correct name for the library to be searched for

2014-07-14 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119245/#review62347 --- Ship it! Thanks a lot. Please someone commit it. - Jarosław

Re: Review Request 119246: Missing include_directories() in SQLite driver

2014-07-14 Thread Vadim Zhukov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119246/ --- (Updated July 14, 2014, 10:26 p.m.) Status -- This change has been m

Re: Review Request 119222: Make labels inline-editable

2014-07-14 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/#review62339 --- Much cooler! Thanks. Noticed: - when double clicking it's sup

Re: How to fix import of headings in DOC/DOCX (text:h instead of text:p)?

2014-07-14 Thread Friedrich W. H. Kossebau
Hi Lassi, Am Sonntag, 13. Juli 2014, 19:36:27 schrieb Lassi Nieminen: > Docx the magical file is DocxXmlDocumentReader.cpp (don't have code atm., > so method names may be slightly different) > > For style the structure seems to be: > > > > In read_pPr you need to add a call to new method > >

Re: Review Request 119222: Make labels inline-editable

2014-07-14 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated July 14, 2014, 7:11 p.m.) Review request for Calligra and Jarosł

Re: Review Request 119222: Make labels inline-editable

2014-07-14 Thread Adam Pigg
> On July 13, 2014, 6:45 p.m., Kamil Łysik wrote: > > libs/koreport/items/label/KoReportDesignerItemLabel.cpp, line 193 > > > > > > I got build error: adding > > #include > > fixed this. Is this include

Re: Review Request 119222: Make labels inline-editable

2014-07-14 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119222/ --- (Updated July 14, 2014, 5:05 p.m.) Review request for Calligra and Jarosł