Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

2014-07-06 Thread Laurent Montel
> On juil. 6, 2014, 2:10 après-midi, Friedrich W. H. Kossebau wrote: > > Was this ever committed? > > Camilla Boemann wrote: > Don't think so but I also don't think it belongs to calligra anymore. > Laurent, what do you think? > > Inge Wallin wrote: > Hmm, why not? What would be a bett

Re: Review Request 109994: New implementation for handling formulas

2014-07-06 Thread Yue Liu
> On July 6, 2014, 2:13 p.m., Friedrich W. H. Kossebau wrote: > > Hi. Discussion on this review request has stopped more than a year ago. I > > hope it could be started again soon by perhaps an updated version of the > > patch? Without that though we better close this RR, given there is no > >

Re: Review Request 114193: Added new cmake macros and find_package modules, added new dependency libodfgen, deleted writerperfect, use libodfgen instead

2014-07-06 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114193/ --- (Updated July 7, 2014, 2:36 a.m.) Status -- This change has been mar

Review Request 119150: Fix "Go to last record" button in KexiRecordNavigator being wrongly enabled on last record, when insertion was enabled

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119150/ --- Review request for Calligra and Jarosław Staniek. Repository: calligra

Re: Review Request 111734: add test for ppt conversion

2014-07-06 Thread Jos van den Oever
> On July 6, 2014, 2:18 p.m., Friedrich W. H. Kossebau wrote: > > Hi. Given the reservation and no other supporters, could this review > > request please either be supported by somebody else or be closed for now, > > given the inactivity? I still think it is good to land this patch. It is diff

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

2014-07-06 Thread Camilla Boemann
> On July 6, 2014, 2:10 p.m., Friedrich W. H. Kossebau wrote: > > Was this ever committed? > > Camilla Boemann wrote: > Don't think so but I also don't think it belongs to calligra anymore. > Laurent, what do you think? > > Inge Wallin wrote: > Hmm, why not? What would be a better plac

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

2014-07-06 Thread Inge Wallin
> On July 6, 2014, 2:10 p.m., Friedrich W. H. Kossebau wrote: > > Was this ever committed? > > Camilla Boemann wrote: > Don't think so but I also don't think it belongs to calligra anymore. > Laurent, what do you think? Hmm, why not? What would be a better place? I agree that if all word p

Re: Review Request 118172: wpg2odg import filter: add missing include dir

2014-07-06 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118172/ --- (Updated July 6, 2014, 3:59 p.m.) Status -- This change has been mar

Re: Review Request 116533: Bug 142563

2014-07-06 Thread Jigar Raisinghani
> On April 11, 2014, 4:39 a.m., Inge Wallin wrote: > > sheets/functions/math.xml, line 836 > > > > > > I'm not sure this text is an improvement. For one thing, it's not > > "greater than" if the number is alread

Re: Review Request 110928: Always save the position of a shape

2014-07-06 Thread Inge Wallin
> On July 6, 2014, 2:51 p.m., Camilla Boemann wrote: > > After having read the discussion I come out on the side of dismissing, > > based on the following: > > > > 1) It is not done as a result of a bug > > 2) It produces more output xml > > 3) The spec states what default values are, and we tr

Re: Review Request 116990: Deduplicate dirs in one more place where moc fails due to too long command line.

2014-07-06 Thread Friedrich W. H. Kossebau
> On Juli 6, 2014, 3:12 nachm., Friedrich W. H. Kossebau wrote: > > where is remove_duplicated_include_directories() from? could not find it > > documented in the cmake docs, and google does not tell me more. > > > > Testing on my OpenSUSE I get: > > CMake Error at sheets/shape/CMakeLists.txt:9

Re: Review Request 116990: Deduplicate dirs in one more place where moc fails due to too long command line.

2014-07-06 Thread Andrius da Costa Ribas
> On Julho 6, 2014, 3:12 p.m., Friedrich W. H. Kossebau wrote: > > where is remove_duplicated_include_directories() from? could not find it > > documented in the cmake docs, and google does not tell me more. > > > > Testing on my OpenSUSE I get: > > CMake Error at sheets/shape/CMakeLists.txt:9

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

2014-07-06 Thread Camilla Boemann
> On July 6, 2014, 2:10 p.m., Friedrich W. H. Kossebau wrote: > > Was this ever committed? Don't think so but I also don't think it belongs to calligra anymore. Laurent, what do you think? - Camilla --- This is an automatically generat

Re: Review Request 116990: Deduplicate dirs in one more place where moc fails due to too long command line.

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116990/#review61729 --- where is remove_duplicated_include_directories() from? could n

Re: Review Request 110928: Always save the position of a shape

2014-07-06 Thread Camilla Boemann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110928/#review61727 --- After having read the discussion I come out on the side of dis

Re: Review Request 112904: Pivot Tables Improved

2014-07-06 Thread Jigar Raisinghani
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112904/ --- (Updated July 6, 2014, 2:32 p.m.) Status -- This change has been mar

Re: Review Request 115110: Modify vc-based macros to allow passing flags.

2014-07-06 Thread Friedrich W. H. Kossebau
Am Sonntag, 19. Januar 2014, 03:42:38 schrieb Andrius da Costa Ribas: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115110/ > ---

Re: Review Request 114439: Support QT_NO_PRINTER and QT_NO_NETWORKINTERFACE

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114439/#review61723 --- Was this ever committed? - Friedrich W. H. Kossebau On Dez.

Re: Review Request 114193: Added new cmake macros and find_package modules, added new dependency libodfgen, deleted writerperfect, use libodfgen instead

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114193/#review61722 --- What is the state of this review request? - Friedrich W. H. K

Re: Review Request 111734: add test for ppt conversion

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111734/#review61721 --- Hi. Given the reservation and no other supporters, could this

Re: Review Request 110928: Always save the position of a shape

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110928/#review61720 --- Ping. Could someone of the discussion participants either push

Re: Review Request 109994: New implementation for handling formulas

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109994/#review61719 --- Hi. Discussion on this review request has stopped more than a

Re: Review Request 118172: wpg2odg import filter: add missing include dir

2014-07-06 Thread Heiko Becker
> On Juli 6, 2014, 1:52 nachm., Friedrich W. H. Kossebau wrote: > > Hi Heiko, do you have commit access to KDE repos? If not please tell, so > > somebody else can commit this for you. > > > > In "master" branch this problem has meanwhile already been fixed > > independently. No, i don't have

Re: Review Request 108924: added some more grammer checking and auto corrections in autocorrection.xml , en_US.xml

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108924/#review61717 --- Was this ever committed? - Friedrich W. H. Kossebau On Feb.

Re: Review Request 109278: fix preedit string problem when layout the document, fix input method query problem in artistictext tool

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/109278/#review61716 --- What is the state of this RR? It has been committed, no? If th

Re: Review Request 108481: Temporarily swith to path tool to change shape parameters without double click to switch tool

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/108481/#review61715 --- Given the reservations against the changes in this RR and no f

Re: Review Request 106283: Add Blob Tool to Calligra

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/106283/#review61714 --- Hi José, there has been no further work or discussion on the r

Re: Review Request 102716: Implement a playback device context for EMF and the start of an EMFPLUS parser.

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/102716/#review61712 --- Last work on the branch done more than 2 years ago (at least b

Re: Review Request 118172: wpg2odg import filter: add missing include dir

2014-07-06 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118172/#review61711 --- Ship it! Hi Heiko, do you have commit access to KDE repos? If

Re: Review Request 119139: Fix moving of shapes in groups in shape layers

2014-07-06 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119139/ --- (Updated Juli 6, 2014, 11:38 vorm.) Status -- This change has been m

Re: Review Request 119136: Fix issue with resolving version of plugins (at least) on Linux

2014-07-06 Thread Jarosław Staniek
> On July 5, 2014, 7:35 p.m., Adam Pigg wrote: > > does this not need to be calligra-wide? or use a calligre > > solution...sureley there are other apps with plugin loading issues? Ultimately, yes. I observed that version numbers are not necessarily checked everywhere. We can propose that. For

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-07-06 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118532/#review61679 --- Ship it! This looks good. I didn't look through the whole pa

Re: Review Request 119139: Fix moving of shapes in groups in shape layers

2014-07-06 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119139/#review61680 --- Ship it! Ship It! - Boudewijn Rempt On July 5, 2014, 10:26