> On July 6, 2014, 2:18 p.m., Friedrich W. H. Kossebau wrote: > > Hi. Given the reservation and no other supporters, could this review > > request please either be supported by somebody else or be closed for now, > > given the inactivity?
I still think it is good to land this patch. It is different from runtest.sh in that it allows you to catch changes in the ppt to odp conversion even if you were not looking for them specifically. The test compares the whole file and not just a few xpath expressions. The upside is the coverage. The downside is that is it less specific, but that is fine. For specific tests we have runtests.sh. - Jos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/111734/#review61721 ----------------------------------------------------------- On July 26, 2013, 8:41 p.m., Jos van den Oever wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/111734/ > ----------------------------------------------------------- > > (Updated July 26, 2013, 8:41 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > To test ppt conversion the simplest approach is to take a ppt file, convert > it to odp and check that the output is exactly the same. > This test does that for a simple two slide presentation with a diagram. > > > Diffs > ----- > > filters/stage/powerpoint/CMakeLists.txt b434bef > filters/stage/powerpoint/tests/CMakeLists.txt PRE-CREATION > filters/stage/powerpoint/tests/TestPPT.h PRE-CREATION > filters/stage/powerpoint/tests/TestPPT.cpp PRE-CREATION > filters/stage/powerpoint/tests/data/diagram.ppt PRE-CREATION > filters/stage/powerpoint/tests/data/diagram_odp/META-INF/manifest.xml > PRE-CREATION > filters/stage/powerpoint/tests/data/diagram_odp/content.xml PRE-CREATION > filters/stage/powerpoint/tests/data/diagram_odp/meta.xml PRE-CREATION > filters/stage/powerpoint/tests/data/diagram_odp/settings.xml PRE-CREATION > filters/stage/powerpoint/tests/data/diagram_odp/styles.xml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/111734/diff/ > > > Testing > ------- > > Ran the test multiple times and it passes every time. It is repeatable. > > > Thanks, > > Jos van den Oever > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
