Re: Static code analysis

2014-06-05 Thread Inge Wallin
On Thursday, June 05, 2014 22:02:43 Jaroslaw Staniek wrote: > Dear All, > Just added a list of tools known as useful in C/C++ static code > analysis. Some are already used in our development, some need > volunteers. This is rather very interesting area - let's make Calligra > more bug-free, and it'

Review Request 118582: Fix crash when removing a Database Connection.

2014-06-05 Thread Radosław Wicik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118582/ --- Review request for Calligra, Oleg Kukharchuk, Adam Pigg, Jarosław Staniek,

Re: Static code analysis

2014-06-05 Thread René J.V. Bertin
On Jun 05, 2014, at 22:30, Boudewijn Rempt wrote: >> Prepare yourselves to scan through a lot of output! :) > > Did you do that for calligra? Anything we need to fix asap? No, I said "on my own code", didn't I? :) I did just verify what I said about the scan-build script on a KDE-related cmake

Build failed in Jenkins: calligra_master » All,LINBUILDER #567

2014-06-05 Thread KDE CI System
See Changes: [staniek] Fix crash when accessing a query with duplicated table names -- [...truncated 9934 lines...] Linking CXX shared library ../../lib/libkformula.so [

Re: Static code analysis

2014-06-05 Thread Boudewijn Rempt
On Thu, 5 Jun 2014, "René J.V. Bertin" wrote: On Jun 05, 2014, at 22:02, Jaroslaw Staniek wrote: volunteers. This is rather very interesting area - let's make Calligra more bug-free, and it's relatively cheap! http://community.kde.org/Calligra/Testing#Static_Code_Analysis I've already appli

Re: Static code analysis

2014-06-05 Thread René J.V. Bertin
On Jun 05, 2014, at 22:02, Jaroslaw Staniek wrote: > volunteers. This is rather very interesting area - let's make Calligra > more bug-free, and it's relatively cheap! > > http://community.kde.org/Calligra/Testing#Static_Code_Analysis I've already applied clang's analyser on code of my own, with

Re: Review Request 116611: Eigen3 support

2014-06-05 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116611/#review59359 --- Ship it! Ship It! - Boudewijn Rempt On March 21, 2014, 8:4

Re: Review Request 117460: Krita: Adds grid presets in powers of 2 to the grid menu, from 2x2 to 64x64.

2014-06-05 Thread Bart Kelsey
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117460/ --- (Updated June 5, 2014, 8:20 p.m.) Status -- This change has been mar

Re: Review Request 117461: Krita: Adds default hotkeys for toggling the grid and snap to grid

2014-06-05 Thread Bart Kelsey
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117461/ --- (Updated June 5, 2014, 8:20 p.m.) Status -- This change has been mar

Static code analysis

2014-06-05 Thread Jaroslaw Staniek
Dear All, Just added a list of tools known as useful in C/C++ static code analysis. Some are already used in our development, some need volunteers. This is rather very interesting area - let's make Calligra more bug-free, and it's relatively cheap! http://community.kde.org/Calligra/Testing#Static_

Build failed in Jenkins: calligra_master » All,LINBUILDER #566

2014-06-05 Thread KDE CI System
See Changes: [boud] Don't crash if the user's first click is ctrl-alt click -- [...truncated 9919 lines...] [ 50%] Building CXX object plugins/textshape/CMakeFiles/call

Re: Review Request 118519: Fix crash when accessing a query with duplicated table names

2014-06-05 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/ --- (Updated June 5, 2014, 7:49 p.m.) Status -- This change has been mar

Re: Review Request 118519: Fix crash when accessing a query with duplicated table names

2014-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/#review59356 --- This review has been submitted with commit f8f807ebd94d9f9596

Re: Review Request 118519: Fix crash when accessing a query with duplicated table names

2014-06-05 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/#review59355 --- Ship it! Added test cases and passes with patch applied - Ad

Re: Review Request 118571: Added query parse tests

2014-06-05 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118571/#review59354 --- libs/db/tests/TestConnection.cpp

Build failed in Jenkins: calligra_master » All,LINBUILDER #565

2014-06-05 Thread KDE CI System
See Changes: [kossebau] add Okular generator for ODT (and OTT) files [kossebau] Also support DOC and DOCX formats with the ODT Okular generator plugin -- [...truncated

Re: Review Request 118510: small rework of product sets: products, features and product sets

2014-06-05 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118510/ --- (Updated June 5, 2014, 5:52 p.m.) Review request for Calligra, Yue Liu, B

Review Request 118571: Added query parse tests

2014-06-05 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118571/ --- Review request for Calligra and Jarosław Staniek. Repository: calligra

Re: Review Request 118510: small rework of product sets: products, features and product sets

2014-06-05 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118510/#review59353 --- Ship it! Ship It! - Boudewijn Rempt On June 5, 2014, 5:52

Re: Review Request 118541: Add generator plugin for Okular to support ODT, DOC, DOCX

2014-06-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118541/#review59352 --- This review has been submitted with commit e4d6c50c5a66955a58

Re: Review Request 118541: Add generator plugin for Okular to support ODT, DOC, DOCX

2014-06-05 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118541/ --- (Updated June 5, 2014, 5:30 p.m.) Status -- This change has been mar

Re: [Marble-devel] Review Request 118495: Marble input handling refactor. Support for mouse, touch and pinch in MarbleQuickItem.

2014-06-05 Thread Friedrich W. H. Kossebau
Hi, (cc: to calligra-devel just for heads-up, please remove when replying) Am Dienstag, 3. Juni 2014, 11:49:04 schrieb Adam Dabrowski: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/11

Build failed in Jenkins: calligra_master » All,LINBUILDER #564

2014-06-05 Thread KDE CI System
See Changes: [ahiemstra] gemini: Remove obsolete timers in switchToSketch/Desktop [ahiemstra] gemini: Use the desktop dialog for opening images from the welcome screen ---

Build failed in Jenkins: calligra_master » All,LINBUILDER #563

2014-06-05 Thread KDE CI System
See Changes: [boud] Updates for the clone tool -- [...truncated 9905 lines...] [ 49%] Building CXX object plugins/formulashape/CMakeFiles/kformula.dir/elements/UnknownE

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-05 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118532/#review59328 --- Looks better but there are still some minor things. But if it'

Re: Review Request 118532: Proper handling of sections for Words and Author

2014-06-05 Thread Denis Kuplyakov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118532/ --- (Updated June 5, 2014, 12:41 p.m.) Review request for Calligra, Camilla B

Re: Review Request 118541: Add generator plugin for Okular to support ODT, DOC, DOCX

2014-06-05 Thread Sven Langkamp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118541/#review59326 --- Ship it! Ship It! - Sven Langkamp On June 4, 2014, 8:46 p.

Build failed in Jenkins: calligra_master » All,LINBUILDER #562

2014-06-05 Thread KDE CI System
See Changes: [dimula73] Refactor KoResourceServer to allow storing shared pointers -- [...truncated 9925 lines...] [ 50%] Building CXX object plugins/textshape/CMakeFil