-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118541/#review59352
-----------------------------------------------------------


This review has been submitted with commit 
e4d6c50c5a66955a58fdcb31a8e470d292310ac2 by Friedrich W. H. Kossebau to branch 
master.

- Commit Hook


On June 4, 2014, 8:46 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118541/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 8:46 p.m.)
> 
> 
> Review request for Calligra and Sven Langkamp.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> As I now and then try to view ODT documents directly in KDevelop... I wanted 
> better support. Given that Calligra parts are no longer KPart-based, and 
> writing a sublime-MVC-based plugin for KDevelop (like done with Okteta) would 
> take some time, having a plugin for Okular (KPart) seems like a quick and 
> generally nice solution.
> 
> Picked up some old work of slangkamp for another generator plugin for Okular 
> which support ODT. Also added desktop files to extend support for DOC and 
> DOCX (like done with PPT/PPTX). Could be extended for other doc formats for 
> which there are 2odt/words filters, but first would like to see how this is 
> accepted.
> 
> ((Somehow I still think Okular should be part of Calligra, given the overlap 
> of problem/solution space... but well :) ))
> 
> Used pattern OKULAR_GENERATOR_* to already match the pattern used in proposal 
> in r118510.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 256d810 
>   cmake/productsets/all.cmake 778f9c0 
>   cmake/productsets/desktop.cmake 97ff7e8 
>   extras/CMakeLists.txt e603883 
>   extras/okularodtgenerator/CMakeLists.txt PRE-CREATION 
>   extras/okularodtgenerator/OkularOdtGenerator.h PRE-CREATION 
>   extras/okularodtgenerator/OkularOdtGenerator.cpp PRE-CREATION 
>   extras/okularodtgenerator/libokularGenerator_odt.desktop PRE-CREATION 
>   extras/okularodtgenerator/okularApplication_odt.desktop PRE-CREATION 
>   extras/okularodtgenerator/okularOdt.desktop PRE-CREATION 
>   filters/words/docx/import/CMakeLists.txt 036e828 
>   filters/words/docx/import/libokularGenerator_docx_calligra.desktop 
> PRE-CREATION 
>   filters/words/docx/import/okularApplication_docx_calligra.desktop 
> PRE-CREATION 
>   filters/words/docx/import/okularDocx_calligra.desktop PRE-CREATION 
>   filters/words/msword-odf/CMakeLists.txt 8342552 
>   filters/words/msword-odf/libokularGenerator_doc_calligra.desktop 
> PRE-CREATION 
>   filters/words/msword-odf/okularApplication_doc_calligra.desktop 
> PRE-CREATION 
>   filters/words/msword-odf/okularDoc_calligra.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118541/diff/
> 
> 
> Testing
> -------
> 
> Could view DOC and DOCX files in Okular, as well as had better ODT display 
> (Okular's native ODT support is not that good).
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to