Re: Review Request 118517: New brush stabilizer

> On June 4, 2014, 9:26 p.m., Juan Luis Boya García wrote: > > That's probably not a bug. See you have set 768 ms as stabilization time. > > This means the points painted will be the mean of those you actually drew > > during the last 768 ms. That's a huge time frame and fast movements are > >

Re: Review Request 118532: Proper handling of sections for Words and Author

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118532/#review59262 --- libs/kotext/KoSection.h

Re: Review Request 118519: Fix crash when accessing a query with duplicated table names

> On June 4, 2014, 9:08 p.m., Adam Pigg wrote: > > I was wonderingthis seems like it would suit a unit-test. I know we > > arent set up for unit-test yet but we could start somewhere. 2 tests could > > show a valid query passing, and an incorrect query returning the > > appropriate failu

Re: Review Request 118517: New brush stabilizer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118517/#review59247 --- That's probably not a bug. See you have set 768 ms as stabiliz

Re: Review Request 118519: Fix crash when accessing a query with duplicated table names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/#review59245 --- I was wonderingthis seems like it would suit a unit-test.

Review Request 118541: Add generator plugin for Okular to support ODT, DOC, DOCX

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118541/ --- Review request for Calligra and Sven Langkamp. Repository: calligra Des

Re: Review Request 118517: New brush stabilizer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118517/#review59241 --- Hi, Juan! Your patch gives quite interesting results, I like

Re: Review Request 118510: small rework of product sets: products, features and product sets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118510/ --- (Updated June 4, 2014, 8:17 p.m.) Review request for Calligra, Yue Liu, B

Re: Review Request 118532: Proper handling of sections for Words and Author

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118532/ --- (Updated June 4, 2014, 7:51 p.m.) Review request for Calligra, Camilla Bo

Re: Review Request 118510: small rework of product sets: products, features and product sets

> On June 4, 2014, 5:16 p.m., Inge Wallin wrote: > > CalligraProducts.cmake, line 255 > > > > > > OPD?? Hups :/ Fixed in RR. But needs someone to fix in 2.8 branch, otherwise this filter will stay unbuilt there

Re: Review Request 118510: small rework of product sets: products, features and product sets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118510/ --- (Updated June 4, 2014, 7:39 p.m.) Review request for Calligra, Yue Liu, B

Re: Review Request 118532: Proper handling of sections for Words and Author

> On June 4, 2014, 5:03 p.m., Inge Wallin wrote: > > libs/kotext/KoTextEditor_format.cpp, lines 464-465 > > > > > > Language and naming issue: Are these two really plurals? Yes, because really it is a QList< KoS

Re: Review Request 118532: Proper handling of sections for Words and Author

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118532/#review59220 --- I find the delete code way to complex to review just now - I d

Re: Review Request 118510: small rework of product sets: products, features and product sets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118510/#review59222 --- CalligraProducts.cmake

Re: Review Request 118532: Proper handling of sections for Words and Author

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118532/#review59217 --- I have looked through this patch and in general it looks very

Review Request 118532: Proper handling of sections for Words and Author

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118532/ --- Review request for Calligra, Camilla Boemann, Inge Wallin, and Dan Leinir

Review Request 118519: Fix crash when accessing a query with duplicated table names

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118519/ --- Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam

Review Request 118517: New brush stabilizer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118517/ --- Review request for Calligra, Dmitry Kazakov, Sven Langkamp, and Boudewijn R

Re: Review Request 118510: small rework of product sets: products, features and product sets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118510/#review59129 --- However, looking a the diff, I'd say that the new code is much

Re: Review Request 118510: small rework of product sets: products, features and product sets

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118510/#review59128 --- "Especially given that Krita devs have not picked up this for