Review Request 116915: Bug305618

2014-03-19 Thread Wenchao Li
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116915/ --- Review request for Calligra. Repository: calligra Description ---

Re: Review Request 116893: On closing the content writer do not expect it to be allocated

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116893/#review53463 --- This review has been submitted with commit 6c53d6fc56bde86907

Re: Review Request 116904: Fix crash on exporting report to a spreadsheet/text doc in a non-writable dir

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116904/#review53462 --- This review has been submitted with commit 8cef87fde082f4b5e3

Re: Review Request 116904: Fix crash on exporting report to a spreadsheet/text doc in a non-writable dir

2014-03-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116904/ --- (Updated March 19, 2014, 9:50 p.m.) Status -- This change has been m

Re: Review Request 116893: On closing the content writer do not expect it to be allocated

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116893/#review53461 --- This review has been submitted with commit 0b29857b0459ff9c16

Re: Review Request 116904: Fix crash on exporting report to a spreadsheet/text doc in a non-writable dir

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116904/#review53460 --- This review has been submitted with commit 74ee314a15a047e63d

Re: Review Request 116893: On closing the content writer do not expect it to be allocated

2014-03-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116893/ --- (Updated March 19, 2014, 9:50 p.m.) Status -- This change has been m

Re: Review Request 116904: Fix crash on exporting report to a spreadsheet/text doc in a non-writable dir

2014-03-19 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116904/#review53459 --- Ship it! Ship It! - Adam Pigg On March 19, 2014, 3:32 p.m.

Re: Review Request 116893: On closing the content writer do not expect it to be allocated

2014-03-19 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116893/#review53458 --- Ship it! Ship It! - Boudewijn Rempt On March 19, 2014, 10:

Re: Review Request 116889: Added 'NOT LIKE' SQL operator support in kexi queries.

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116889/#review53457 --- This review has been submitted with commit bba5b11ec4b6a6f963

Re: Review Request 116889: Added 'NOT LIKE' SQL operator support in kexi queries.

2014-03-19 Thread Radosław Wicik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116889/ --- (Updated March 19, 2014, 8:44 p.m.) Status -- This change has been m

Re: Review Request 116889: Added 'NOT LIKE' SQL operator support in kexi queries.

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116889/#review53456 --- This review has been submitted with commit 26818f22b2669f72a6

Re: Review Request 116746: Implementing "Do you want to open exported document?" question dialog after exporting report to Text/Spreadsheet/as Web Page.

2014-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116746/#review53441 --- This review has been submitted with commit ca54a66277d79c6eb3

Review Request 116904: Fix crash on exporting report to a spreadsheet/text doc in a non-writable dir

2014-03-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116904/ --- Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam

Re: Review Request 116889: Added 'NOT LIKE' SQL operator support in kexi queries.

2014-03-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116889/#review53424 --- Ship it! Good Job! - Jarosław Staniek On March 18, 2014, 1

Re: Review Request 116889: Added 'NOT LIKE' SQL operator support in kexi queries.

2014-03-19 Thread Jarosław Staniek
> On March 19, 2014, 2:53 p.m., Adam Pigg wrote: > > Would it be appropriate to add an example db with this, and an associated > > test to /test/parser and tests/features? Yes, we're planning a policy of adding unit/functional tests for all new features. A template would come soon after 2.8.1

Re: Review Request 116889: Added 'NOT LIKE' SQL operator support in kexi queries.

2014-03-19 Thread Adam Pigg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116889/#review53420 --- Would it be appropriate to add an example db with this, and an

Re: Review Request 116746: Implementing "Do you want to open exported document?" question dialog after exporting report to Text/Spreadsheet/as Web Page.

2014-03-19 Thread Vishwa Modi
> On March 18, 2014, 9:46 p.m., Vishwa Modi wrote: > > Ship It! > > Vishwa Modi wrote: > happened by mistake. > > Jarosław Staniek wrote: > OK, it can be pushed (please compose the commit message carefully). > Reviewboard does not push automatically. I tried pushing the code. It gives

Review Request 116893: On closing the content writer do not expect it to be allocated

2014-03-19 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116893/ --- Review request for Calligra. Repository: calligra Description ---

Re: Review Request 116746: Implementing "Do you want to open exported document?" question dialog after exporting report to Text/Spreadsheet/as Web Page.

2014-03-19 Thread Jarosław Staniek
> On March 18, 2014, 9:46 p.m., Vishwa Modi wrote: > > Ship It! > > Vishwa Modi wrote: > happened by mistake. OK, it can be pushed (please compose the commit message carefully). Reviewboard does not push automatically. - Jarosław