----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116893/#review53463 -----------------------------------------------------------
This review has been submitted with commit 6c53d6fc56bde869071382c143eb278e4d1380ee by Jaroslaw Staniek to branch calligra/2.8. - Commit Hook On March 19, 2014, 9:50 p.m., Jarosław Staniek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116893/ > ----------------------------------------------------------- > > (Updated March 19, 2014, 9:50 p.m.) > > > Review request for Calligra. > > > Repository: calligra > > > Description > ------- > > On closing the content writer do not expect it to be allocated > > This fixes assertion in KoSimpleOdsDocument::createContent() where content > stays unallocated if the filepath points to a nonwritable directory. Manifest > and body are both allocated so I left the relevant assertions and conditions > intact. > > Needed to fix bug 332293 for 2.8.1. > > > Diffs > ----- > > libs/odf/KoOdfWriteStore.cpp 083c8cb5230ab4a5e1ea3b7c5ee890321349e783 > > Diff: https://git.reviewboard.kde.org/r/116893/diff/ > > > Testing > ------- > > Documents open and save as before, tested with reports too > > > Thanks, > > Jarosław Staniek > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel