Re: Review Request 112584: Autocomplete feature for Calligra Sheets

2013-09-08 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112584/#review39585 --- Ship it! Looks good now. Just fix the trivial things I pointe

Re: Review Request 112584: Autocomplete feature for Calligra Sheets

2013-09-08 Thread Jigar Raisinghani
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112584/ --- (Updated Sept. 8, 2013, 4:07 p.m.) Review request for Calligra and Inge Wa

Re: Review Request 112584: Autocomplete feature for Calligra Sheets

2013-09-08 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112584/#review39584 --- Looks pretty good, except the disregard for the Calligra coding

Re: Review Request 112584: Autocomplete feature for Calligra Sheets

2013-09-08 Thread Jigar Raisinghani
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112584/ --- (Updated Sept. 8, 2013, 2:51 p.m.) Review request for Calligra and Inge Wa

Re: How to merge rebased branch properly?

2013-09-08 Thread Dmitry Kazakov
Hi, Lukas! The only problem of a rebasing a pushed branch is that you cannot push it again due to non-fast-forward-merge. If your commits are not destroyed by the rebase (that could happen with merge commits actually) you can still push them into repository, but under a different HEAD. So to do t

Re: How to merge rebased branch properly?

2013-09-08 Thread Lukast dev
DmitryK mentioned some other possibility to preserve history, to create another branch and merge that new branch. I would like to preserve the commits as I dropped some code that might be needed again and squash will destroy history of the branch. Dmitry,can you explain the solution with more det

Re: Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author

2013-09-08 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111914/ --- (Updated Sept. 8, 2013, 10:33 a.m.) Review request for Calligra. Descrip

Re: Review Request 111914: Add support for annotations, a.k.a. notes, to Words and Author

2013-09-08 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111914/ --- (Updated Sept. 8, 2013, 10:32 a.m.) Review request for Calligra. Changes

Re: Review Request 112584: Autocomplete feature for Calligra Sheets

2013-09-08 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112584/#review39556 --- Hmm, is there a problem? I can't find any diff. - Inge Wallin