----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112584/#review39585 -----------------------------------------------------------
Ship it! Looks good now. Just fix the trivial things I pointed out below and you can merge. Good job! sheets/ui/CellEditor.h <http://git.reviewboard.kde.org/r/112584/#comment29166> Hmm, why comment out instead of just remove? sheets/ui/CellEditor.cpp <http://git.reviewboard.kde.org/r/112584/#comment29167> Still some missing spaces. Like around '=' and after ',' sheets/ui/CellEditor.cpp <http://git.reviewboard.kde.org/r/112584/#comment29169> Some people dislike spaces at the end of lines. :) sheets/ui/CellEditor.cpp <http://git.reviewboard.kde.org/r/112584/#comment29168> We should always use braces around the clauses in 'if' even if it's just one line. - Inge Wallin On Sept. 8, 2013, 4:07 p.m., Jigar Raisinghani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112584/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2013, 4:07 p.m.) > > > Review request for Calligra and Inge Wallin. > > > Description > ------- > > This feature enables you to save time by just clicking/selecting redundant > entries to fill a cell in the sheet. > > How to use: > 1) Open a file containing some data/ Open a blank file and enter some data > 2) Try entering data in the columns which already contain some data which has > atleast first 3 characters similar to some other entry in the same column > > You can see that a popup appears near your cell which gives you suggestions > based on the text you have entered in the current cell. You can chose any > suggestion by clicking on it or using the arrow keys to navigate through > options and using Tab/Enter to fill in the suggestion in the cell. > > Optimization: > 1) Currently, Autocomplete has been optimized to a large extent by Hash Tables > > Further Optimization possible(but not yet done): > 1) Navigate only through cells which are already populated using nextInRow() > and nextInColumn() to populate the HashTable. > 2) Use thread to populate Hash Table when sheet is loaded. This process if > run in background, can optimize the feature further. > > Further Improvements possible: > 1) Currently, the choices filled in the suggestion list are based on Most > Recently Used 3 entries. Autocomplete can be made smarter by populating the > list with 3 Most Redundant entries but this would increase the complexity and > optimization would again be needed. > > > Diffs > ----- > > sheets/ui/CellEditor.h 92bdad6 > sheets/ui/CellEditor.cpp d539c06 > > Diff: http://git.reviewboard.kde.org/r/112584/diff/ > > > Testing > ------- > > The feature works successfully for fair amount of data. Testing yet to be > done for Huge Files. > > > Thanks, > > Jigar Raisinghani > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
