Re: Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-07-28 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111773/#review36693 --- Hello Jos, have you been doing some comparison in speed and me

Re: Review Request 111615: Wrap KoShapeBackground in QSharedPointer

2013-07-28 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111615/#review36692 --- I have not tested the patch but from the looks it looks ok, bes

Re: Review Request 111751: Refresh TaskStatusItemModel when a Node changes

2013-07-28 Thread Alvaro Soliverez
> On July 28, 2013, 7 p.m., Friedrich W. H. Kossebau wrote: > > plan/libs/models/kpttaskstatusmodel.cpp, line 724 > > > > > > If calling "refresh()" at the end anyway, then all the logic with the > > row before a

Review Request 111773: Add api for writing ODF that is generated from the ODF RNG file

2013-07-28 Thread Jos van den Oever
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111773/ --- Review request for Calligra. Description --- This patch is also avail

Re: Review Request 111751: Refresh TaskStatusItemModel when a Node changes

2013-07-28 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111751/#review36677 --- Fix would work, but... I am not happy with it, sorry. I hope th

Re: Review Request 109887: Create a stream reader better suited for ODF than QXmlStreamReader

2013-07-28 Thread Thorsten Zachmann
On Saturday, July 27, 2013 03:07:27 PM Inge Wallin wrote: > On Saturday, July 27, 2013 05:56:23 Thorsten Zachmann wrote: > > Hello Inge, > > > > On Friday, July 26, 2013 07:16:54 PM Inge Wallin wrote: > > > --- > > > This is an automatically

Re: Review Request 111667: Make libcalligrachartshape a static lib, rename to libchartshapecore and no longer install it

2013-07-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111667/#review36653 --- This review has been submitted with commit e38cd1a860dea9e96d0

Re: Review Request 111703: Link calligrakdgantt only against Qt libs, not KDE4_KDECORE_LIBS

2013-07-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111703/#review36652 --- This review has been submitted with commit 02dc529a03704e0b599

Re: Review Request 111657: Project performance chart refresh

2013-07-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111657/#review36651 --- This review has been submitted with commit f49d388c9ffd0c13a9a

Re: Review Request 111615: Wrap KoShapeBackground in QSharedPointer

2013-07-28 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111615/#review36644 --- cmake/modules/FindVc.cmake

Re: Review Request 111615: Wrap KoShapeBackground in QSharedPointer

2013-07-28 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111615/ --- (Updated July 28, 2013, 9:46 a.m.) Review request for Calligra and Jan Ham