Re: Review Request 111329: Do not install Braindump Core's StatesRegistry.h

2013-06-30 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111329/#review35335 --- Ship it! For now at least: don't install it. - Inge Wallin

Re: Review Request 111326: Install all calligralibs headers in ${INCLUDE_INSTALL_DIR}/calligra

2013-06-30 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111326/#review35334 --- No comment on the patch yet but it seems to me that you have a

My Akademy

2013-06-30 Thread Jaroslaw Staniek
Hi, I'll be attending QtCS (Monday-Tuesday [1]) so there's chance I'll come to say hello @ Akademy too. [1] http://qt-project.org/groups/qt-contributors-summit-2013/wiki -- regards / pozdrawiam, Jaroslaw Staniek Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org Qt for Tizen | h

Re: Review Request 111326: Install all calligralibs headers in ${INCLUDE_INSTALL_DIR}/calligra

2013-06-30 Thread Elvis Stansvik
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111326/#review35331 --- Nice patch. Having it configurable might be asking for trouble

Re: Review Request 111043: Fix possibly memory leak in sidewinder code by not called destructor on incomplete type of QTextDocument

2013-06-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111043/#review35330 --- This review has been submitted with commit cc7f4fe0575cbfcbd72

Re: Review Request 111043: Fix possibly memory leak in sidewinder code by not called destructor on incomplete type of QTextDocument

2013-06-30 Thread Friedrich W. H. Kossebau
> On June 29, 2013, 3:30 a.m., Inge Wallin wrote: > > filters/sheets/excel/sidewinder/excel.cpp, lines 1647-1650 > > > > > > normally this would be: > > > > : Record(book) > > , d(new Tx0Reco

Re: Review Request 111043: Fix possibly memory leak in sidewinder code by not called destructor on incomplete type of QTextDocument

2013-06-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111043/#review35329 --- This review has been submitted with commit 4a48f2e57e5948b6662

Re: Review Request 111043: Fix possibly memory leak in sidewinder code by not called destructor on incomplete type of QTextDocument

2013-06-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111043/ --- (Updated June 30, 2013, 9:53 p.m.) Status -- This change has been mar

Re: Review Request 111326: Install all calligralibs headers in ${INCLUDE_INSTALL_DIR}/calligra

2013-06-30 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111326/ --- (Updated June 30, 2013, 9:38 p.m.) Review request for Calligra. Changes

Re: Review Request 111306: add optional DEVEL tag to calligra_define_product(...) for automatic creation of x_DEVEL products

2013-06-30 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111306/ --- (Updated June 30, 2013, 7:41 p.m.) Review request for Calligra. Changes

Review Request 111329: Do not install Braindump Core's StatesRegistry.h

2013-06-30 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111329/ --- Review request for Calligra and Cyrille Berger Skott. Description ---

Review Request 111328: Install all krita headers in ${INCLUDE_INSTALL_DIR}/krita

2013-06-30 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111328/ --- Review request for Calligra and Boudewijn Rempt. Description --- ...

Review Request 111326: Install all calligralibs headers in ${INCLUDE_INSTALL_DIR}/calligra

2013-06-30 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111326/ --- Review request for Calligra. Description --- While almost all headers

Re: Review Request 111321: Solve bug 283164: delete key doesn't delete multiple cells

2013-06-30 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111321/#review35315 --- has my backing :) - C. Boemann On June 30, 2013, 2:55 a.m.,

Re: Review Request 111306: add optional DEVEL tag to calligra_define_product(...) for automatic creation of x_DEVEL products

2013-06-30 Thread Friedrich W. H. Kossebau
> On June 30, 2013, 8:37 a.m., Sune Vuorela wrote: > > afaik, the DEVEL keyword is only used by cpack which no one is using > > (because it is kind of too primitive to be useful and not compliant with > > various rules set up by distributors). It is kind of usable on windows > > though. dunno

Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111305/#review35312 --- This review has been submitted with commit 8c14fc24834c3255e5c

Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111305/ --- (Updated June 30, 2013, 4:50 p.m.) Status -- This change has been mar

Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-30 Thread Friedrich W. H. Kossebau
> On June 30, 2013, 3:26 p.m., Inge Wallin wrote: > > Yes, the patch looks good. Ship it! > > > > And I agree with boemann that we don't want "ko" in the library directory > > names. Okay, shipping. Thanks. > On June 30, 2013, 3:26 p.m., Inge Wallin wrote: > > filters/sheets/excel/export/CM

Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-30 Thread Friedrich W. H. Kossebau
> On June 29, 2013, 7:45 a.m., C. Boemann wrote: > > as for the subdirs i think the should be without prefix. the prefix is > > something we have to endure with librarynames. Okay. So will come up with a patch in the next weeks which removes the ko-prefix also from the existing subdirs. Unless

Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-30 Thread Friedrich W. H. Kossebau
> On June 29, 2013, 4:02 a.m., Thorsten Zachmann wrote: > > How about using the prefix cs for calligrasuite instead of ko? IMHO indeed a prefix different from "ko" and more reflecting the name "Calligra (Suite)" should be used in Calligra libs, agreed. But... that should be then applied to eve

Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-30 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111305/#review35306 --- Ship it! Yes, the patch looks good. Ship it! And I agree wit

Re: Review Request 111305: "ko"-prefix installed, but so far namespace-less libs: msooxml, odfreader, vectorimage, textlayout

2013-06-30 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111305/#review35297 --- namespacing libs sounds like a good idea. The patch looks great

Re: Review Request 111306: add optional DEVEL tag to calligra_define_product(...) for automatic creation of x_DEVEL products

2013-06-30 Thread Sune Vuorela
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111306/#review35296 --- afaik, the DEVEL keyword is only used by cpack which no one is