Re: Review Request 110910: Refactored context menu creation code out of KoResourceItemChooser and into its own QMenu class

2013-06-12 Thread Sascha Suelzer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110910/ --- (Updated June 12, 2013, 8:01 p.m.) Review request for Calligra. Changes

Re: Review Request 110965: fix broken conversion of results from koscript code evaluation in KRScriptHandler::evaluate()

2013-06-12 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110965/#review34247 --- Thanks for testing this Friedrich, Unfortunately this patch rev

Re: Review Request 110928: Always save the position of a shape

2013-06-12 Thread Sebastian Sauer
> On June 10, 2013, 5:52 p.m., C. Boemann wrote: > > I still don't see the relation to the bug nor do I understand why we need > > to save 0,0 > > Inge Wallin wrote: > Ah, now I understand why everybody focusses on the bug. I was unclear in > my description. "This bug" in the description

Re: Review Request 110928: Always save the position of a shape

2013-06-12 Thread Elvis Stansvik
> On June 10, 2013, 5:52 p.m., C. Boemann wrote: > > I still don't see the relation to the bug nor do I understand why we need > > to save 0,0 > > Inge Wallin wrote: > Ah, now I understand why everybody focusses on the bug. I was unclear in > my description. "This bug" in the description

Re: Review Request 110928: Always save the position of a shape

2013-06-12 Thread Inge Wallin
> On June 10, 2013, 5:52 p.m., C. Boemann wrote: > > I still don't see the relation to the bug nor do I understand why we need > > to save 0,0 > > Inge Wallin wrote: > Ah, now I understand why everybody focusses on the bug. I was unclear in > my description. "This bug" in the description