> On June 10, 2013, 5:52 p.m., C. Boemann wrote:
> > I still don't see the relation to the bug nor do I understand why we need 
> > to save 0,0
> 
> Inge Wallin wrote:
>     Ah, now I understand why everybody focusses on the bug.  I was unclear in 
> my description.  "This bug" in the description is about the bug I described, 
> not the bug in bugzilla.  I was just mentioning the bug in bugzilla because 
> it provided me with a file where I noticed the problem first time.
>     
>     Regarding why we need to save 0,0...  Can you point me to the place in 
> the spec where it says that 0,0 is the default value? If not, there's your 
> answer.
> 
> Elvis Stansvik wrote:
>     In 19.573.5 the spec refers to 5.2.1 of the SVG spec which says 0,0 is 
> the default [1]. Not 100% sure this is what we're talking about here, so 
> someone please fill me in if I'm wrong :)
>     
>     [1] http://www.w3.org/TR/2003/REC-SVG11-20030114/struct.html#SVGElement

No, this is the svg element.  We are talking about svg:x and svg:y attributes.  
But there is probably a relation.  


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110928/#review34071
-----------------------------------------------------------


On June 10, 2013, 7:18 p.m., Inge Wallin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110928/
> -----------------------------------------------------------
> 
> (Updated June 10, 2013, 7:18 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Description
> -------
> 
> When a shape is in the position 0, 0 and there are no other transformations, 
> the position will not be saved back. In other words, there will be an 
> svg:height and svg:width but no svg:x or svg:y.  I noticed this while trying 
> to fix https://bugs.kde.org/show_bug.cgi?id=184727.
> 
> This patch fixes that the code doesn't save the position.  I suggest that we 
> apply it to 2.7 as well and maybe also to 2.6.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoShape.cpp 6d14a8c 
> 
> Diff: http://git.reviewboard.kde.org/r/110928/diff/
> 
> 
> Testing
> -------
> 
> Tested with the file mentioned above.
> 
> 
> Thanks,
> 
> Inge Wallin
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to