Review Request 109071: Add a PRODUCTSET build config parameter (values ACTIVE, CREATIVE, DESKTOP, ALL)

2013-02-20 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109071/ --- Review request for Calligra. Description --- PRODUCTSET is a substitu

Re: Review Request 109057: Normalize SIGNAL and SLOT signatures in kexi

2013-02-20 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109057/#review27795 --- Thanks for the effort. I have several broken connections such a

Review Request 109057: Normalize SIGNAL and SLOT signatures in kexi

2013-02-20 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109057/ --- Review request for Calligra and Jarosław Staniek. Description --- Thi

Re: Check for Qt classes that should not be used

2013-02-20 Thread Jean-Nicolas Artaud
2013/2/20 Sven Langkamp > On Wed, Feb 20, 2013 at 9:35 AM, Inge Wallin wrote: > > As you may have noticed, I have taken some interest in EBN, the KDE > static > > code checker[1]. One of the categories there is "Check for Qt classes > that > > should not be used" where it recommends to use e.g.

Re: Check for Qt classes that should not be used

2013-02-20 Thread Sven Langkamp
On Wed, Feb 20, 2013 at 9:35 AM, Inge Wallin wrote: > As you may have noticed, I have taken some interest in EBN, the KDE static > code checker[1]. One of the categories there is "Check for Qt classes that > should not be used" where it recommends to use e.g. KTabBar instead of QTabBar > and so on

Check for Qt classes that should not be used

2013-02-20 Thread Inge Wallin
As you may have noticed, I have taken some interest in EBN, the KDE static code checker[1]. One of the categories there is "Check for Qt classes that should not be used" where it recommends to use e.g. KTabBar instead of QTabBar and so on. What's our opinion on that? That should be something v