-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109071/
-----------------------------------------------------------
Review request for Calligra.
Description
-------
PRODUCTSET is a substitute for the old non-exclusive options CREATIVEONLY and
TINY (which then are handled exclusively, eek), with migration support for
CREATIVEONLY flag. Predefined hardcoded productsets are ACTIVE, CREATIVE,
DESKTOP, and ALL (as fallback and default).
Patch also turns buildsystem to have a SHOULD_BUILD for each product
(app/plugin), which then all get turned on centrally in groups depending on the
productset, instead of everywhere having overlapping and hard to oversee
if-else blocks deciding what gets build and what not.
Not the perfect final solution, but a first step into the right direction IMHO.
Known issues:
* BUILD_AUTHOR is not yet set
Patch can be also tested as branch addProductSetBuildParameter-kossebau.
Diffs
-----
words/part/CMakeLists.txt 56b8c6f
words/part/Info.plist.template 97e1728
words/part/main.cpp 875eb5d
words/part/words.desktop 35bc4c3
words/app/main.cpp PRE-CREATION
words/app/words.desktop PRE-CREATION
words/app/CMakeLists.txt PRE-CREATION
words/app/Info.plist.template PRE-CREATION
stage/part/Info.plist.template 857a8d7
stage/part/main.cpp 5ef9509
stage/part/stage.desktop 447858f
tools/CMakeLists.txt eefe95b
words/CMakeLists.txt e6336a2
3rdparty/CMakeLists.txt a300bd2
CMakeLists.txt d9945a1
filters/CMakeLists.txt 5acecef
filters/sheets/CMakeLists.txt 351a8e2
filters/words/CMakeLists.txt 0c2107c
libs/CMakeLists.txt 2036cf5
plugins/CMakeLists.txt 0e87b1e
sheets/CMakeLists.txt 9f96e41
stage/CMakeLists.txt 94dd31c
stage/app/CMakeLists.txt PRE-CREATION
stage/app/Info.plist.template PRE-CREATION
stage/app/main.cpp PRE-CREATION
stage/app/stage.desktop PRE-CREATION
stage/part/CMakeLists.txt de57a0f
Diff: http://git.reviewboard.kde.org/r/109071/diff/
Testing
-------
Thanks,
Friedrich W. H. Kossebau
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
