Re: [calligra] kexi/widget/fields: Fixed KexiFieldListModel

On Monday 26 November 2012 21:33:19 Oleg Kukharchuk wrote: > Git commit 175e0957fdb9ad56c5665a23b3c8c39fff5ad703 by Oleg > Kukharchuk. Committed on 26/11/2012 at 21:30. > Pushed by okukharchuk into branch 'master'. > > Fixed KexiFieldListModel > > Added caption for a second section of the hea

Re: Review Request: Sort styles according to usage in the docker's combos

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107445/#review22611 --- I've noted several issues, but all in all I'm close to saying i

Re: Review Request: Sort styles according to usage in the docker's combos

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107445/ --- (Updated Nov. 26, 2012, 9:27 p.m.) Review request for Calligra, Inge Walli

Re: Review Request: fixed SqlitePrepared statement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107475/#review22610 --- This review has been submitted with commit 6a4428cf2a3f9120aba

Re: Review Request: fixed KexiFieldListModel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107481/#review22605 --- This review has been submitted with commit 175e0957fdb9ad56c56

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

On Monday 26 November 2012 Nov, Thorsten Zachmann wrote: > On Monday 26 November 2012 19:52:33 Boudewijn Rempt wrote: > > if (type == "numfile") > > return Value(KoDocument::documentList() ? > > KoDocument::documentList()->count() : 0); > > This is a number and not a bool > > Thorsten

Re: Review Request: fixed SqlitePrepared statement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107475/#review22604 --- BTW, since this is a bug fix, please also cherry-pick to callig

Re: Review Request: fixed KexiFieldListModel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107481/#review22602 --- Ship it! Ship It! - Jarosław Staniek On Nov. 26, 2012, 8:08

Re: Using Sheets as a library

Regarding licenses, I'd like to add: kexi/ is full-LGPL for one major reason that's convenient license management: we never know what part (and when) we'd like to pull off to a reusable library. This even applies to tests sometimes... -- regards / pozdrawiam, Jaroslaw Staniek Kexi & Calligra & K

Re: Using Sheets as a library

On Monday 26 November 2012 Nov, Philip Van Hoof wrote: > On Mon, 2012-11-26 at 10:29 +0100, Inge Wallin wrote: > > Hi Inge, > > > The idea is that all of Sheets and in fact all of Calligra should be under > > LGPL. There are a couple of exceptions, mostly for historical reasons: > > Krita > >

Re: Review Request: fixed SqlitePrepared statement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107475/#review22600 --- This review has been submitted with commit b1f113527016cf0b353

Re: Using Sheets as a library

On Monday 26 November 2012 Nov, Philip Van Hoof wrote: > Hi guys, > > For the purpose of a custom made and specialized Qt application will > need to adapt the CMakeFile.txt of Sheets in such a way that the > non-installed calligrasheetscommon_LIB gets installed and that its > header files will bec

Re: Review Request: fixed SqlitePrepared statement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107475/#review22598 --- Ship it! Ship It! - Jarosław Staniek On Nov. 26, 2012, 1:45

Re: Review Request: fixed SqlitePrepared statement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107475/#review22597 --- Good job! Feel free to port to Predicate... - Jarosław Staniek

Re: Review Request: fixed KexiFieldListModel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107481/ --- (Updated Nov. 26, 2012, 8:08 p.m.) Review request for Calligra, Jarosław S

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

On Monday 26 November 2012 19:52:33 Boudewijn Rempt wrote: > if (type == "numfile") > return Value(KoDocument::documentList() ? > KoDocument::documentList()->count() : 0); This is a number and not a bool Thorsten ___ calligra-devel mailing l

Re: 2.6 RC1

The tag is set on: http://quickgit.kde.org/?p=calligra.git&a=commit&h=ffcaab20c1f3371c7df1f2c981f313aee4c85727 -- Cyrille Berger Skott ___ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

> On Nov. 26, 2012, 6:51 p.m., Thorsten Zachmann wrote: > > sheets/functions/information.cpp, lines 193-201 > > > > > > This seems to be wrong. It should return the number of of documents in > > the vlaue and not t

Re: Review Request: fixed KexiFieldListModel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107481/#review22594 --- Ship it! good job! kexi/widget/fields/KexiFieldListModel.cpp

Review Request: fixed KexiFieldListModel

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107481/ --- Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tani

Re: Review Request: Updating the test case for numfile in TestInformationFunctions

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107459/#review22589 --- libs/main/KoApplication.cpp

Re: Review Request: Sort styles according to usage in the docker's combos

> On Nov. 25, 2012, 9:19 p.m., C. Boemann wrote: > > libs/kotext/styles/KoCharacterStyle.cpp, line 1965 > > > > > > is this used anywhere and for what? Ah, this is a left-over from my StylesManager branch. Well, t

Review Request: fixed SqlitePrepared statement

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107475/ --- Review request for Calligra, Jarosław Staniek, Adam Pigg, and Dimitrios Tani

Re: Using Sheets as a library

On Mon, 2012-11-26 at 10:29 +0100, Inge Wallin wrote: Hi Inge, > The idea is that all of Sheets and in fact all of Calligra should be under > LGPL. There are a couple of exceptions, mostly for historical reasons: Krita > and a couple of 3rd party libraries. What is important in that case is t

Re: Using Sheets as a library

Hih Philip, On Monday, November 26, 2012 09:33:42 Philip Van Hoof wrote: > On Mon, 2012-11-26 at 09:22 +0100, Philip Van Hoof wrote: > > [deleted] > > pvanhoof@lors:~/repos/kde4/calligra/sheets$ grep "GNU General" * -R | > > cut -d ":" -f -1 | sort | uniq > > dialogs/ConsolidateDetailsWidget.ui

Re: Using Sheets as a library

On Mon, 2012-11-26 at 09:22 +0100, Philip Van Hoof wrote: Uhrg, Monday morning. I'm not awake yet. I promise I will get coffee in a minute. > I also noticed that all the files under sheets/ are annotated at the top So this isn't correct. Not all the files under sheets/ are annotated at the top t

Using Sheets as a library

Hi guys, For the purpose of a custom made and specialized Qt application will need to adapt the CMakeFile.txt of Sheets in such a way that the non-installed calligrasheetscommon_LIB gets installed and that its header files will become available. Right now for demo purposes to and learn whether or