Re: Review Request: metadata

2012-11-18 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107371/ --- (Updated Nov. 18, 2012, 10:49 p.m.) Review request for Calligra. Descrip

Re: Review Request: metadata

2012-11-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107371/#review22193 --- filters/words/epub/EpubFile.cpp

Re: Review Request: metadata

2012-11-18 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107371/ --- (Updated Nov. 18, 2012, 10:29 p.m.) Review request for Calligra. Changes

Re: Review Request: metadata

2012-11-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107371/#review22191 --- The language is supposed to be according to RFC5646, whereas yo

Re: Review Request: metadata

2012-11-18 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107371/ --- (Updated Nov. 18, 2012, 9:11 p.m.) Review request for Calligra. Descript

Re: Calligra 2.5.4

2012-11-18 Thread Inge Wallin
On Sunday, November 18, 2012 19:48:29 Cyrille Berger Skott wrote: > On Friday 16 Nov 2012, Cyrille Berger wrote: > > Hi, > > > > I have been too busy and a bit too stressed to make the 2.5.4 release > > the last two weeks. But now, it should be fine, so I suggest tagging > > tomorrow and release n

Re: Review Request: metadata

2012-11-18 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107371/ --- (Updated Nov. 18, 2012, 8:28 p.m.) Review request for Calligra. Descript

Re: Review Request: metadata

2012-11-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107371/#review22187 --- libs/main/KoDocumentInfo.cpp

Re: Review Request: metadata

2012-11-18 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107371/#review22186 --- Found one small issue. I'm going to actually test the patch wh

Re: Review Request: metadata

2012-11-18 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107371/ --- (Updated Nov. 18, 2012, 8:14 p.m.) Review request for Calligra. Summary

Re: Review Request: Move fileproperties plugin out of libs/main into tools/properties (and make it work again)

2012-11-18 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107353/#review22185 --- Ship it! A ship it from me too. Looks good, and a good find.

Review Request: metadata

2012-11-18 Thread mojtaba shahi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107371/ --- Review request for Calligra. Description --- Add to meta.xml and the

Re: Calligra 2.5.4

2012-11-18 Thread Cyrille Berger Skott
On Friday 16 Nov 2012, Cyrille Berger wrote: > Hi, > > I have been too busy and a bit too stressed to make the 2.5.4 release > the last two weeks. But now, it should be fine, so I suggest tagging > tomorrow and release next week. Tag is set on 12ceeecfb3ae24b929ff63f4c62f58f4ac4d1765: http://quic

Re: Review Request: Use for default Author profile also any existing info about emailaddress and phonenumbers

2012-11-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107370/#review22176 --- This review has been submitted with commit 218501ec0afa5dca6d0

Re: Review Request: Use for default Author profile also any existing info about emailaddress and phonenumbers

2012-11-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107370/#review22175 --- This review has been submitted with commit 3eb3fdf73561f7b1fb6

Re: Review Request: Use for default Author profile also any existing info about emailaddress and phonenumbers

2012-11-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107370/#review22173 --- Ship it! yes please backport - C. Boemann On Nov. 18, 2012,

Re: Review Request: Fix saving of Author info for non-default and non-anonymous case

2012-11-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107366/#review22172 --- This review has been submitted with commit 2c81d140b0b5582dd31

Review Request: Use for default Author profile also any existing info about emailaddress and phonenumbers

2012-11-18 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107370/ --- Review request for Calligra and C. Boemann. Description --- Let's use

Re: Review Request: Fix saving of Author info for non-default and non-anonymous case

2012-11-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107366/#review22170 --- This review has been submitted with commit e220923e6d89da29990

Re: Review Request: Fix saving of Author info for non-default and non-anonymous case

2012-11-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107366/#review22168 --- Ship it! yes please backport - C. Boemann On Nov. 18, 2012,

Review Request: Fix saving of Author info for non-default and non-anonymous case

2012-11-18 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107366/ --- Review request for Calligra and C. Boemann. Description --- KoConfigA

Re: Review Request: Move fileproperties plugin out of libs/main into tools/properties (and make it work again)

2012-11-18 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107353/ --- (Updated Nov. 18, 2012, 1:36 p.m.) Review request for Calligra and David F

Re: Review Request: Move fileproperties plugin out of libs/main into tools/properties (and make it work again)

2012-11-18 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107353/#review22159 --- Ship it! I agree with the move. Have you checked with the auth

Re: [PATCH] videoshape thumbnails only with phononexperimental.

2012-11-18 Thread Boudewijn Rempt
On Sunday 18 November 2012 Nov, Boudewijn Rempt wrote: > > Thanks for your patches I'll apply them now to 2.6 and test. > Too late -- that's what I get for not reading all my mail :-). I was already wondering why they didn't apply! -- Boudewijn Rempt http://www.valdyas.org, http://www.krita.

Re: [PATCH] videoshape thumbnails only with phononexperimental.

2012-11-18 Thread Boudewijn Rempt
On Friday 16 November 2012 Nov, Raúl Sánchez Siles wrote: > Hello: > > I've reworked(simplified) commit d3190e8a47e12db282363829d4e5f733451e4a13 > on > master and backported to 2.6 branch. This avoids build failure when > phononexperimental is not available. > > Simplification consists o