----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107353/ -----------------------------------------------------------
(Updated Nov. 18, 2012, 1:36 p.m.) Review request for Calligra and David Faure. Changes ------- Adding David to requested reviewers, for the answer to Boud's question "whether he had any reason to keep it in libs/main?". Description (updated) ------- Did you know that Calligra also installs a fileproperties dialog plugin, to show the general meta data and the author info? I did not, until I wondered where those pages in the fileproperties dialog plugin came from (e.g. select "Properties" on a ODF file in Dolphin and select the "General" or "Last saved by" tabs). This plugin better lives next to its cousin, the thumbnailer plugin, in the tools part of the sources tree (even if developing tools and user tools ideally would be in separate tree branches in the sources). So the attached patch moves all files belonging to this plugin into the new dir "tools/properties" (any better name proposal?). Additionally it makes it also work again, by teaching KoDocumentInfoDlg to also deal with a KoDocumentInfo object without an attached KoDocument, like in the case of the fileproperties plugin, and turning off the entries in the "General" tab which are redundant in the fileproperties dialog (path & type). Okay to backport to 2.6? Setting the Authors profile does not work correctly currently, but that is a separate problem I will look next into. The dialog shows at least any set Author info correctly. Background info: * the kpropsdlg plugin was originally added to lib/kofficecore by Simon Hausmann with what is now 642a4005ee5be7844efcd97090c135180bad3e07 (back in 2000) * it was resurrected by David Faure and kept in libs/main (successor of lib/kofficecore) with 64b06543d48444a10caf21389a028bdc1300c43b (in 2010) Diffs ----- libs/main/CMakeLists.txt ae68a2b libs/main/KoDocInfoPropsFactory.cpp c1d89b9 libs/main/KoDocumentInfoDlg.cpp 920c05c libs/main/koDocumentInfoAboutWidget.ui a5133ed libs/main/kodocinfopropspage.desktop 5acfbc0 tools/CMakeLists.txt b0eb900 tools/properties/CMakeLists.txt PRE-CREATION tools/properties/KoDocInfoPropsFactory.cpp PRE-CREATION tools/properties/calligradocinfopropspage.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/107353/diff/ Testing ------- Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
