warning: overflow in implicit constant conversion in KoShape.cpp

2012-08-18 Thread André Wöbbeking
Hi, when compiling Calligra I get: calligra/libs/flake/KoShape.cpp: In constructor 'KoShapePrivate::KoShapePrivate(KoShape*)': calligra/libs/flake/KoShape.cpp:105:48: warning: overflow in implicit constant conversion [-Woverflow] calligra/libs/flake/KoShape.cpp:105:48: warning: overflow in impl

Re: Review Request: Introduce Author into the Calligra family

2012-08-18 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106064/ --- (Updated Aug. 19, 2012, 6:20 a.m.) Review request for Calligra. Changes

Re: Review Request: Introduce Author into the Calligra family

2012-08-18 Thread Gopalakrishna Bhat
> On Aug. 18, 2012, 8:24 a.m., Jarosław Staniek wrote: > > words/part/author/main.cpp, line 29 > > > > > > Why to hardcode it here? No other app, despote potential gains, do that > > in Calligra. You may want to put

Re: Review Request: Main Window: Workaround for visual glitch of Oxygen style for menu widget

2012-08-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105996/#review17689 --- This review has been submitted with commit 8822b410951d6576bcb

Re: Review Request: remove deprecated and unneeded setting of spacings/margins using KDialog::*Hint()

2012-08-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106078/#review17687 --- This review has been submitted with commit 5a58202b950c62565e3

Re: Review Request: remove deprecated and unneeded setting of spacings/margins using KDialog::*Hint()

2012-08-18 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106078/#review17686 --- Ship it! sounds safe enough to me - C. Boemann On Aug. 18,

Re: Review Request: Fixed bug: New Kexi project file created in current directory

2012-08-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106023/#review17685 --- This review has been submitted with commit 572bae0147689a95079

Re: Review Request: Missing table kexi__parts is no longer a critical error in Kexi

2012-08-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106027/#review17684 --- This review has been submitted with commit 1a35d590f75f4cbb5ed

Re: Review Request: Main Window: Workaround for visual glitch of Oxygen style for menu widget

2012-08-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105996/#review17683 --- This review has been submitted with commit 9c59935313acb628c82

Re: Review Request: Main Window: Workaround for visual glitch of Oxygen style for menu widget

2012-08-18 Thread Smit Patel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105996/#review17682 --- Ship it! Ship It! - Smit Patel On Aug. 15, 2012, 9:27 p.m.,

Re: Review Request: rename "import" action to "open as new"

2012-08-18 Thread Jaroslaw Staniek
On 15 August 2012 15:13, Boudewijn Rempt wrote: > On Tuesday 14 August 2012 Aug, Jaroslaw Staniek wrote: > >> Definitely Import and Open has been merged into one in many apps these >> days. > > Well, I don't know. I guess it depends, on the one hand you've got weird > separations of import/open a

Re: 2.6 Release Schedule

2012-08-18 Thread Jaroslaw Staniek
On 18 August 2012 11:39, Boudewijn Rempt wrote: > On Saturday 18 August 2012 Aug, Jaroslaw Staniek wrote: >> On 18 August 2012 08:08, Cyrille Berger Skott wrote: >> > On Tuesday 07 Aug 2012, Boudewijn Rempt wrote: >> >> On Tuesday 07 August 2012 Aug, Cyrille Berger Skott wrote: >> >> > Hi, >> >>

Re: Bump CMake minimum requirement to 2.8.0

2012-08-18 Thread Cyrille Berger Skott
On Saturday 18 Aug 2012, Gopalakrishna Bhat wrote: > code exists. On seeing the git history I see that this was added to enable > "make benchmark". Any idea what is the purpose of the above code snippet? > and is this option still being used by anyone? not entirely sure since I copy/paste it from t

Review Request: remove deprecated and unneeded setting of spacings/margins using KDialog::*Hint()

2012-08-18 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106078/ --- Review request for Calligra. Description --- KDialog::marginHint() an

Re: Review Request: fix kexi_sqlite3_dump build breakage

2012-08-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106076/#review17663 --- This review has been submitted with commit 6ac1f1a59ae11fa70eb

Re: Review Request: fix kexi_sqlite3_dump build breakage

2012-08-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106076/#review17661 --- Ship it! Ship It! - Jarosław Staniek On Aug. 18, 2012, 2:01

Re: Bump CMake minimum requirement to 2.8.0

2012-08-18 Thread Gopalakrishna Bhat
So, now I upgraded the minimum requirement to 4.8.0 and I get this error CMake Error at cmake/modules/MacroCalligraAddBenchmark.cmake:75 (add_custom_target): add_custom_target cannot create target "buildtests" because another target with the same name already exists. The existing target is a

Review Request: fix kexi_sqlite3_dump build breakage

2012-08-18 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106076/ --- Review request for Calligra and Jarosław Staniek. Description --- The

Re: 2.6 Release Schedule

2012-08-18 Thread Boudewijn Rempt
On Saturday 18 August 2012 Aug, Jaroslaw Staniek wrote: > On 18 August 2012 08:08, Cyrille Berger Skott wrote: > > On Tuesday 07 Aug 2012, Boudewijn Rempt wrote: > >> On Tuesday 07 August 2012 Aug, Cyrille Berger Skott wrote: > >> > Hi, > >> > > >> > Here is the suggested schedule for 2.6: > >> >

Review Request: add commands for chart operations

2012-08-18 Thread Brijesh Patel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106070/ --- Review request for Calligra, Inge Wallin and C. Boemann. Description -

Re: Review Request: Introduce Author into the Calligra family

2012-08-18 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106064/#review17643 --- words/part/author/CAuAboutData.h

Re: calligra 2.5.1

2012-08-18 Thread Jaroslaw Staniek
On 18 August 2012 08:06, Cyrille Berger Skott wrote: > Hi, > > If there is no objection, I had like to move the 2.5.1 tagging to next Friday. > It seems there are important bug fixes, already. > > For the future, I guess we should always plan shorter cycle for .1 and have > the maintenance release

Re: 2.6 Release Schedule

2012-08-18 Thread Boudewijn Rempt
On Saturday 18 August 2012 Aug, Cyrille Berger Skott wrote: > On Tuesday 07 Aug 2012, Boudewijn Rempt wrote: > > On Tuesday 07 August 2012 Aug, Cyrille Berger Skott wrote: > > > Hi, > > > > > > Here is the suggested schedule for 2.6: > > > > > > September 7th alpha tagging > > > September 28th br

Re: calligra 2.5.1

2012-08-18 Thread Boudewijn Rempt
On Saturday 18 August 2012 Aug, Cyrille Berger Skott wrote: > Hi, > > If there is no objection, I had like to move the 2.5.1 tagging to next > Friday. > It seems there are important bug fixes, already. Yes :-). I'm all for it! > > For the future, I guess we should always plan shorter cycle

Re: 2.6 Release Schedule

2012-08-18 Thread Jaroslaw Staniek
On 18 August 2012 08:08, Cyrille Berger Skott wrote: > On Tuesday 07 Aug 2012, Boudewijn Rempt wrote: >> On Tuesday 07 August 2012 Aug, Cyrille Berger Skott wrote: >> > Hi, >> > >> > Here is the suggested schedule for 2.6: >> > >> > September 7th alpha tagging >> > September 28th branch+beta taggi