Re: RC readiness, not

2012-07-13 Thread Sven Langkamp
On Thu, Jul 12, 2012 at 4:46 PM, Cyrille Berger Skott wrote: > On Thursday 12 Jul 2012, C. Boemann wrote: > > Hi > > > > We still have two release blockers, so it would seem we need another week > > before RC tagging > > That would be very inconvenient for me. I guess there is the possibility > fo

Re: RC readiness, not

2012-07-13 Thread C. Boemann
On Friday 13 July 2012 21:29:50 Cyrille Berger Skott wrote: > On Friday 13 Jul 2012, Thorsten Zachmann wrote: > > > And yes, Words is not considered end-user ready, this why the release > > > has the 2.5 version number and not 3.0. > > > > And we still can fix those bugs commit them to master and

Re: RC readiness, not

2012-07-13 Thread Cyrille Berger Skott
On Friday 13 Jul 2012, Thorsten Zachmann wrote: > > And yes, Words is not considered end-user ready, this why the release has > > the 2.5 version number and not 3.0. > > And we still can fix those bugs commit them to master and backport them to > 2.5 so the next releases will be even better then w

Re: Review Request: Perspective grid feature moved to Perspective Assistant

2012-07-13 Thread Shivaraman Aiyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105559/ --- (Updated July 13, 2012, 6:10 p.m.) Review request for Calligra. Changes

Re: RC readiness, not

2012-07-13 Thread Thorsten Zachmann
Hello, On Friday 13 July 2012 16:11:24 Cyrille Berger Skott wrote: > Hum, the question that needs to be answered at this point is: is calligra > 2.5 worse or better than calligra 2.4.3. If it is better (ie no > regressions, more bug fixes more features) then it should be released to > replace 2.4.

Re: RC readiness, not

2012-07-13 Thread Cyrille Berger Skott
Hum, the question that needs to be answered at this point is: is calligra 2.5 worse or better than calligra 2.4.3. If it is better (ie no regressions, more bug fixes more features) then it should be released to replace 2.4.3. However if it is worse (ie regressions), then it should be delayed. A

Re: RC readiness, not

2012-07-13 Thread C. Boemann
On Friday 13 July 2012 15:54:49 Friedrich W. H. Kossebau wrote: > Am Donnerstag, 12. Juli 2012, 17:06:51 schrieb C. Boemann: > > On Thursday 12 July 2012 16:46:34 Cyrille Berger Skott wrote: > > > On Thursday 12 Jul 2012, C. Boemann wrote: > > > > Hi > > > > > > > > We still have two release block

Re: RC readiness, not

2012-07-13 Thread Boudewijn Rempt
On Fri, 13 Jul 2012, Friedrich W. H. Kossebau wrote: I know that sucks for parts of Calligra which might be release-fine for some time already (guess Krita is), but Words as _the_ office program needs more time (and your work). For Krita I actually don't mind too much. I doubt that krita sket

Re: RC readiness, not

2012-07-13 Thread Friedrich W. H. Kossebau
Am Donnerstag, 12. Juli 2012, 17:06:51 schrieb C. Boemann: > On Thursday 12 July 2012 16:46:34 Cyrille Berger Skott wrote: > > On Thursday 12 Jul 2012, C. Boemann wrote: > > > Hi > > > > > > We still have two release blockers, so it would seem we need another > > > week > > > before RC tagging > >

Re: Review Request: fix & improve template generation code

2012-07-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105406/#review15797 --- This review has been submitted with commit cfa5cd3e8bc1395a434

Re: Review Request: fix & improve template generation code

2012-07-13 Thread Friedrich W. H. Kossebau
> On July 13, 2012, 12:36 p.m., Boudewijn Rempt wrote: > > Looks good to me, but I don't think it should be backported. 2.5rc1 is > > going to be tagged today, after all. not backported today, or not at all? after all this also fixes the bad icons currently created, see "Description:" above

Re: Review Request: fix & improve template generation code

2012-07-13 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105406/#review15789 --- Looks good to me, but I don't think it should be backported. 2.

Re: Review Request: fix & improve template generation code

2012-07-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105406/#review15787 --- Ship it! but too late for new 2.5 strings, feel free to backpo

Re: Review Request: fix & improve template generation code

2012-07-13 Thread Friedrich W. H. Kossebau
> On July 13, 2012, 7:05 a.m., C. Boemann wrote: > > I think the select button should stick to custom, but there should be some > > spacing between the two > > Other than that I like it Okay, if you like the button next to the text, just have it :) Adding the spacing could be achieved by chang

Re: Review Request: fix & improve template generation code

2012-07-13 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105406/ --- (Updated July 13, 2012, 12:16 p.m.) Review request for Calligra. Changes

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread Jaroslaw Staniek
On 13 July 2012 11:28, Boudewijn Rempt wrote: > On Friday 13 July 2012 Jul, Jaroslaw Staniek wrote: > >> It was announced and put as RFC on 3rd July: >> >> http://lists.kde.org/?l=calligra-devel&m=134135216226096&w=1 > > Sorry, but that was completely unclear. Clear would have been "proposal for

Re: Review Request: fixes KWOdfWriter to write tracked changes before declarations (ODF 1.2 spec wants that)

2012-07-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105545/#review15776 --- This review has been submitted with commit 51db1de934752bdd3d4

Re: Review Request: fixes KWOdfWriter to write tracked changes before declarations (ODF 1.2 spec wants that)

2012-07-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105545/#review15775 --- This review has been submitted with commit 90d5060a94657856428

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread Boudewijn Rempt
On Friday 13 July 2012 Jul, Jaroslaw Staniek wrote: > It was announced and put as RFC on 3rd July: > > http://lists.kde.org/?l=calligra-devel&m=134135216226096&w=1 Sorry, but that was completely unclear. Clear would have been "proposal for adding sqlite and icu as dependencies to all calligra a

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread Jaroslaw Staniek
On 13 July 2012 10:11, Boudewijn Rempt wrote: > On Friday 13 July 2012 Jul, C. Boemann wrote: >> On Friday 13 July 2012 08:45:13 Cyrille Berger Skott wrote: >> > On Friday 13 Jul 2012, you wrote: >> > > Flexibility is a +1, but one -1 (besides adding further complexity to >> > > cmake files) is th

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread Boudewijn Rempt
On Friday 13 July 2012 Jul, C. Boemann wrote: > > Yeah, I saw that request. But that's not the same same as writing a mail to > > the mailing list announcing extra dependencies. I saw the request, but I > > was blindsided by it as well. > I'm not sure I like it if we make it even easier to ignore

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread C. Boemann
On Friday 13 July 2012 10:07:28 Boudewijn Rempt wrote: > On Friday 13 July 2012 Jul, Jaroslaw Staniek wrote: > > On 13 July 2012 01:12, C. Boemann wrote: > > > No, it's a hard dependency for Words/kotext, but for CREATIVEONLY I > > > have no objection, though it will mean that there will be no tex

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread C. Boemann
On Friday 13 July 2012 10:11:20 Boudewijn Rempt wrote: > On Friday 13 July 2012 Jul, C. Boemann wrote: > > On Friday 13 July 2012 08:45:13 Cyrille Berger Skott wrote: > > > On Friday 13 Jul 2012, you wrote: > > > > Flexibility is a +1, but one -1 (besides adding further complexity to > > > > cmake

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread Boudewijn Rempt
On Friday 13 July 2012 Jul, C. Boemann wrote: > On Friday 13 July 2012 08:45:13 Cyrille Berger Skott wrote: > > On Friday 13 Jul 2012, you wrote: > > > Flexibility is a +1, but one -1 (besides adding further complexity to > > > cmake files) is that these build profiles should only be used for > > >

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread Boudewijn Rempt
On Friday 13 July 2012 Jul, Jaroslaw Staniek wrote: > On 13 July 2012 01:12, C. Boemann wrote: > > > No, it's a hard dependency for Words/kotext, but for CREATIVEONLY I have no > > objection, though it will mean that there will be no textshape either (well > > I > > guess it can be ifdef'ed) >

Re: [calligra] /: Move core parts of KexiDB lib to libcalligradb

2012-07-13 Thread Boudewijn Rempt
On Friday 13 July 2012 Jul, C. Boemann wrote: > No, it's a hard dependency for Words/kotext, but for CREATIVEONLY I have no > objection, though it will mean that there will be no textshape either (well I > guess it can be ifdef'ed) I certainly would hate losing the text tool in Krita... And havi

Re: Review Request: fixes KWOdfWriter to write tracked changes before declarations (ODF 1.2 spec wants that)

2012-07-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105545/#review15770 --- Ship it! sure, thanks - C. Boemann On July 13, 2012, 7:24 a

Review Request: fixes KWOdfWriter to write tracked changes before declarations (ODF 1.2 spec wants that)

2012-07-13 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105545/ --- Review request for Calligra and C. Boemann. Description --- calligra/

Re: Review Request: fix & improve template generation code

2012-07-13 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105406/#review15768 --- I think the select button should stick to custom, but there sho