Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

2012-05-26 Thread Thorsten Zachmann
> On May 26, 2012, 5:44 a.m., Thorsten Zachmann wrote: > > stage/part/animations/strategy/KPrSmilValues.cpp, lines 80-86 > > > > > > When loading a formula the smil:values is not used so I guess it should > > not be

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

2012-05-26 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/#review14200 --- There are still 2 classes in the code for parsing the data. I t

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

2012-05-26 Thread Paul Mendez
> On May 26, 2012, 5:44 a.m., Thorsten Zachmann wrote: > > stage/part/animations/strategy/KPrSmilValues.cpp, lines 80-86 > > > > > > When loading a formula the smil:values is not used so I guess it should > > not be

Re: Review Request: GSoC: Add support of Anim:Formula tag in Stage

2012-05-26 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105030/ --- (Updated May 26, 2012, 7:03 p.m.) Review request for Calligra. Changes -