Review Request: Fix wrongly always present dot behind bullet in preview of the Paragraph dialog

2012-03-25 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104411/ --- Review request for Calligra. Description --- The preview of the Parag

Re: Review Request: Right-align labels on paragraph/character dialogs

2012-03-25 Thread Friedrich W. H. Kossebau
> On March 26, 2012, 4:21 a.m., Thorsten Zachmann wrote: > > In the fonts dialog would it make sense to make the comboboxes the same > > width in the Highlighting section? I mean the width of the first combobox > > after the label. Yes, could be even more eye-friendly, now that I tried it. An

Re: Review Request: Right-align labels on paragraph/character dialogs

2012-03-25 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104408/#review11863 --- In the fonts dialog would it make sense to make the comboboxes

Re: Review Request: Name change of KoShapeBorderModel to KoShapeStrokeModel to make the naming clearer.

2012-03-25 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104405/#review11862 --- Ship it! Please fix the noted things before committing karbo

Re: [calligra] libs/kopageapp: Don't show pageX as nam of the page

2012-03-25 Thread Thorsten Zachmann
Hello, On Sunday, March 25, 2012 22:01:16 C. Boemann wrote: > Hmm isn't loading the wrong time to fix this. Shouldn't it be done on save > or LO and friends will show it wrong to? The problem is that we need to save a name and that is what LO and friendes do to. Thorsten ___

Re: [calligra] libs/kopageapp: Don't show pageX as nam of the page

2012-03-25 Thread C. Boemann
Hmm isn't loading the wrong time to fix this. Shouldn't it be done on save or LO and friends will show it wrong to? On Sunday 25 March 2012 07:32:14 Thorsten Zachmann wrote: > Git commit 4deb1cab33459e7353abb68ccb01dd0b56f4754c by Thorsten Zachmann. > Committed on 25/03/2012 at 07:29. > Pushed by

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread Friedrich W. H. Kossebau
> On March 26, 2012, midnight, C. Boemann wrote: > > i don't care shadow+shape or style > > > > just choose one > > Done, both for 2.4 and master - Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: http://

Re: Review Request: Right-align labels on paragraph/character dialogs

2012-03-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104408/#review11860 --- This review has been submitted with commit b41292de20c2e478dfe

Re: Review Request: have KoConnectionShapeConfigWidget use QFormLayout instead of QGridLayout

2012-03-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104410/#review11858 --- This review has been submitted with commit 8acfb7b7bc0805fad4b

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104409/#review11857 --- i don't care shadow+shape or style just choose one - C. Boem

Re: Review Request: have KoConnectionShapeConfigWidget use QFormLayout instead of QGridLayout

2012-03-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104410/#review11856 --- This review has been submitted with commit 1714396b8411d0afa7b

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread Friedrich W. H. Kossebau
> On March 25, 2012, 11:42 p.m., C. Boemann wrote: > > If you change it to setFrameShadow you can commit that one line. Ah, indeed used the wrong call, should have been setFrameShadow(..). Just the order of calls did not show the error. Then a single s->setFrameStyle(QFrame::HLine | QFrame:

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread Friedrich W. H. Kossebau
> On March 25, 2012, 11:32 p.m., C. Boemann wrote: > > hmm no, the indentation is on purpose > > > > as for the sunken it may be ok, but i'll have to test it first guessed that the indentation is on purpose :) but it is really quite wide IMHO. Surely QToolBox is also not the nicest widget aroun

Re: Review Request: have KoConnectionShapeConfigWidget use QFormLayout instead of QGridLayout

2012-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104410/#review11852 --- Ship it! ok to port - C. Boemann On March 25, 2012, 11:32 p

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104409/#review11851 --- If you change it to setFrameShadow you can commit that one line

Re: Review Request: Right-align labels on paragraph/character dialogs

2012-03-25 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104408/#review11850 --- This review has been submitted with commit 2bfa246f8c4431f2d45

Review Request: have KoConnectionShapeConfigWidget use QFormLayout instead of QGridLayout

2012-03-25 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104410/ --- Review request for Calligra. Description --- Removes that way the gap

Re: Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104409/#review11849 --- hmm no, the indentation is on purpose as for the sunken it may

Review Request: remove wide left margin from KoModeBox

2012-03-25 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104409/ --- Review request for Calligra. Description --- I have found the wider e

Re: Review Request: Right-align labels on paragraph/character dialogs

2012-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104408/#review11848 --- porting too - C. Boemann On March 25, 2012, 11:16 p.m., Frie

Re: Review Request: Right-align labels on paragraph/character dialogs

2012-03-25 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104408/#review11847 --- Ship it! Ship It! - C. Boemann On March 25, 2012, 11:16 p.m

Review Request: Right-align labels on paragraph/character dialogs

2012-03-25 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104408/ --- Review request for Calligra. Description --- See summary. Part of som

Re: Review Request: Name change of KoShapeBorderModel to KoShapeStrokeModel to make the naming clearer.

2012-03-25 Thread Pierre Ducroquet
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104405/#review11845 --- Ship it! Ship It! - Pierre Ducroquet On March 25, 2012, 5:5

Review Request: Name change of KoShapeBorderModel to KoShapeStrokeModel to make the naming clearer.

2012-03-25 Thread Inge Wallin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104405/ --- Review request for Calligra. Description --- This patch changes KoSha

New test failure

2012-03-25 Thread Thorsten Zachmann
Hello, after committing a fix for a bug this this morning, the build bot noticed a new test failure. http://158.36.191.251:8080/viewLog.html?buildId=6052&buildTypeId=bt6 Having looked at the problem, I'm quite sure it is totally unrelated to my changes. It might be caused by now being summer t

[DONE] Re: Disabling Marble map shape for 2.4?

2012-03-25 Thread Friedrich W. H. Kossebau
Am Sonntag, 25. März 2012, 10:49:10 schrieb Cyrille Berger Skott: > On Sunday 18 Mar 2012, Friedrich W. H. Kossebau wrote: > > Am Samstag, 17. März 2012, 23:20:38 schrieb Jaroslaw Staniek: > > > Ok for disabling shapes but I'd like to keep marble for kexi reports and > > > forms. > > > > Sure, onl

Re: Disabling Marble map shape for 2.4?

2012-03-25 Thread Cyrille Berger Skott
On Sunday 18 Mar 2012, Friedrich W. H. Kossebau wrote: > Am Samstag, 17. März 2012, 23:20:38 schrieb Jaroslaw Staniek: > > Ok for disabling shapes but I'd like to keep marble for kexi reports and > > forms. > > Sure, only tested the Marble shape, so will not touch anything else (as > visible in th

Re: Line ends on 2.4

2012-03-25 Thread Thorsten Zachmann
Hello Jean-Nicolas, On Saturday, March 24, 2012 16:50:29 Jean-Nicolas Artaud wrote: > Hello, > > I compiled calligra/2.4 and saw that line ends are not well drawn, is it a > known problem ? > See the attached screenshot! Looks fine for me see http://www.zagge.de/files/lineends.png is that with