-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104405/
-----------------------------------------------------------
Review request for Calligra.
Description
-------
This patch changes KoShapeBorderModel into KoShapeStrokeModel and also a couple
of related classes.
There are 2 reasons for this change:
1. It increases the name describes what it actually is for. There are many
places in the code that looks like:
KoShapeBorderModel *stroke = ...
so naming it "...Stroke..." is both closer to the odf tags and also to the
rest of the code.
2. It reduces the confusion between KoShapeBorderModel and KoBorder which
don't have anything to do with each other.
If this patch is accepted, I want to continue with the KoLineBorder class but I
don't understand that one 100% yet so I want to wait until I do. It's also
possible to follow up with KoBackground -> KoFill, but that's not nearly as
confusing so I don't think it's strictly necessary.
As far as I can remember this topic was up for discussion about a year ago and
was met with general approval but that could also be wishful thinking.
Diffs
-----
libs/flake/CMakeLists.txt 8db919b
karbon/ui/widgets/KarbonSmallStylePreview.cpp d62dfaf
karbon/ui/widgets/KarbonPaletteBarWidget.cpp b92813f
karbon/ui/dockers/KarbonLayerDocker.cpp 2b6eb67
karbon/ui/dockers/KarbonLayerModel.cpp 78d96b1
karbon/ui/KarbonView.cpp a5b5394
karbon/plugins/tools/KarbonPencilTool.cpp 32f1723
karbon/plugins/tools/KarbonPencilTool.h 853e325
karbon/plugins/tools/KarbonGradientTool.cpp 83e1cc5
flow/plugins/dockers/stencilboxdocker/StencilBoxDocker.cpp a2c4818
karbon/common/commands/KarbonBooleanCommand.cpp baab3f6
karbon/plugins/tools/CalligraphyTool/KarbonCalligraphicShape.cpp 454faf4
karbon/plugins/tools/KarbonGradientEditStrategy.cpp 48b313a
filters/karbon/wmf/WmfExport.h b534c58
filters/karbon/wmf/WmfExport.cpp 990b85b
libs/flake/KoCanvasResourceManager.h fdb1bdb
libs/flake/KoCanvasResourceManager.cpp 4b5def5
libs/flake/KoConnectionShapeFactory.cpp 5eab35e
libs/flake/KoFlake.h 10cc38a
libs/flake/KoInsets.h 9188530
libs/flake/KoLineBorder.h 7f7d088
libs/flake/KoLineBorder.cpp f99da3d
libs/flake/KoLineBorderFactory.h f961e88
libs/flake/KoLineBorderFactory.cpp a9fe118
libs/flake/KoPathShape.cpp 2e1bdad
libs/flake/KoPathShapeFactory.cpp b6f5b4d
libs/flake/KoShape.h 8dd981f
libs/flake/KoShape.cpp 5ae13c9
libs/flake/KoShapeBorderFactoryBase.h 11ff35f
libs/flake/KoShapeContainer.cpp ef26d97
libs/flake/KoShapeGroup.cpp 600d039
libs/flake/KoShapeManager.cpp 660e01c
libs/flake/KoShapePainter.cpp 09e2e1c
libs/flake/KoShapeShadow.cpp 75e5538
libs/flake/KoShapeStrokeModel.h 40b50e1
libs/flake/KoShapeStrokeModel.cpp 1041007
libs/flake/KoShape_p.h aafa5d7
libs/flake/commands/KoPathCombineCommand.cpp b752fcf
libs/flake/commands/KoShapeStrokeCommand.h 989749a
libs/flake/commands/KoShapeStrokeCommand.cpp 960aede
libs/flake/svg/SvgParser.cpp 0c74f5f
libs/flake/svg/SvgStyleWriter.cpp e47f78f
libs/flake/tests/CMakeLists.txt e4a4996
libs/flake/tests/TestShapeAt.cpp 8b6c6b1
libs/flake/tests/TestShapeGroupCommand.cpp 3be99b5
libs/flake/tests/TestShapeStrokeCommand.h 142471b
libs/flake/tests/TestShapeStrokeCommand.cpp 898e2ff
libs/flake/tools/KoCreatePathTool.cpp 151a4cf
libs/kopageapp/KoPADocumentModel.cpp 83cf3f1
libs/kopageapp/KoPADocumentStructureDocker.cpp 145d431
libs/textlayout/KoTextLayoutObstruction.cpp e75970a
plugins/artistictextshape/ArtisticTextTool.cpp 8a97623
plugins/chartshape/ChartShape.cpp d0fc3f0
plugins/chartshape/Legend.cpp d6c0774
plugins/commentshape/CommentShape.cpp c12b5d9
plugins/dockers/strokedocker/StrokeDocker.h 835f1e6
plugins/dockers/strokedocker/StrokeDocker.cpp 0d0f67b
plugins/dockers/styledocker/StyleDocker.h 90a8c06
plugins/dockers/styledocker/StyleDocker.cpp 4bc3e1e
plugins/dockers/styledocker/StylePreview.h cf62aeb
plugins/dockers/styledocker/StylePreview.cpp bdbff05
plugins/pathshapes/ellipse/EllipseShapeFactory.cpp ebeb220
plugins/pathshapes/enhancedpath/EnhancedPathParameter.cpp 5dde229
plugins/pathshapes/enhancedpath/EnhancedPathShapeFactory.cpp 3898cda
plugins/pathshapes/rectangle/RectangleShapeFactory.cpp b4e5ec8
plugins/pathshapes/spiral/SpiralShapeFactory.cpp 1080e20
plugins/pathshapes/star/StarShapeFactory.cpp f2ccfca
plugins/treeshape/TreeShape.cpp 0589fa0
words/part/frames/KWCopyShape.cpp 8516de4
Diff: http://git.reviewboard.kde.org/r/104405/diff/
Testing
-------
I tested around as much as I could but i couldn't find any differences in
behaviour from before.
Thanks,
Inge Wallin
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
