Re: Review Request: Fixes multi-line artistic text being saved with wrong coordinates for second and following lines

> On Feb. 29, 2012, 10:25 p.m., Jan Hambrecht wrote: > > plugins/artistictextshape/ArtisticTextShape.cpp, lines 1008-1021 > > > > > > This code block is the problem. I added the if block some time ago to > > save

Re: Review Request: Maintain text selection through undo/redo

> On Feb. 27, 2012, 5:44 p.m., C. Boemann wrote: > > on closer thought i don't think we can ever get this right. The problem is > > that we don't have access to the position before first. When the command is > > created the cursor has alredy been moved. > > > > neverthenless i'l mention that r

Re: Review Request: Fixes multi-line artistic text being saved with wrong coordinates for second and following lines

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104115/#review11040 --- plugins/artistictextshape/ArtisticTextShape.cpp

Re: Review Request: s/Karbon14/Karbon/g for all untranslated strings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104122/#review11039 --- This review has been submitted with commit f8b4f46a0d922b97757

Re: Review Request: s/Karbon14/Karbon/g for all translated strings

> On Feb. 29, 2012, 9:11 p.m., Jan Hambrecht wrote: > > Sure ask them and hopefully it is too much work for them. Well _not_ too much work, of course. - Jan --- This is an automatically generated e-mail. To reply, visit: http://git.revi

Re: Review Request: s/Karbon14/Karbon/g for all translated strings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104125/#review11035 --- Ship it! Sure ask them and hopefully it is too much work for t

Re: Review Request: s/Karbon14/Karbon/g for all untranslated strings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104122/#review11034 --- Ship it! Please go ahead. - Jan Hambrecht On Feb. 29, 2012,

Review Request: s/Karbon14/Karbon/g for all translated strings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104125/ --- Review request for Calligra and Jan Hambrecht. Description --- These

Re: Review Request: Remove obsolete(?) FindCreateResources.cmake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104121/#review11033 --- This review has been submitted with commit 9ea938caffe97eac868

Review Request: s/Karbon14/Karbon/g for all untranslated strings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104122/ --- Review request for Calligra and Jan Hambrecht. Description --- Transl

Re: Review Request: Remove obsolete(?) FindCreateResources.cmake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104121/#review11032 --- Ship it! Yes, it's no longer used. - Boudewijn Rempt On Feb

Review Request: Remove obsolete(?) FindCreateResources.cmake

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104121/ --- Review request for Calligra. Description --- Seems this file is no lo

Re: Review Request: Saving and reloading a file with an Artistic Text object results in spaces added to the text content each time

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104114/#review11027 --- This review has been submitted with commit 96fd35348254dc59b5a

Re: Review Request: load and save draw:id and text:id also as xml:id

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104074/#review11014 --- This review has been submitted with commit 764ba8cb514c2b80013

Re: Review Request: load and save draw:id and text:id also as xml:id

> On Feb. 29, 2012, 9:38 a.m., Elvis Stansvik wrote: > > libs/odf/KoElementReference.h, lines 70-79 > > > > > > why not camel case for these enum values? Well, that's not a hard-and-fast rule either, but in flake ca

Re: Review Request: load and save draw:id and text:id also as xml:id

> On Feb. 29, 2012, 9:34 a.m., Thorsten Zachmann wrote: > > filters/words/oowriter/ExportFilter.cc, line 1365 > > > > > > according to odf 1.2 there is no element text:footnote so maybe better > > remove this chan

Re: Review Request: load and save draw:id and text:id also as xml:id

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104074/#review11009 --- Great work. Minor style issues below. libs/flake/KoShapeSavin

Re: Review Request: load and save draw:id and text:id also as xml:id

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104074/#review11008 --- Ship it! Please fix the pointed out stuff and then commit. f

Re: Review Request: load and save draw:id and text:id also as xml:id

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104074/ --- (Updated Feb. 29, 2012, 9:25 a.m.) Review request for Calligra. Changes

Re: Review Request: load and save draw:id and text:id also as xml:id

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104074/ --- (Updated Feb. 29, 2012, 9:22 a.m.) Review request for Calligra. Changes

Re: Review Request: load and save draw:id and text:id also as xml:id

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104074/#review11005 --- Partial ship-it from my side, up to you zagge? - C. Boemann

Re: Review Request: load and save draw:id and text:id also as xml:id

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104074/ --- (Updated Feb. 29, 2012, 8:15 a.m.) Review request for Calligra. Changes