----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104114/#review11027 -----------------------------------------------------------
This review has been submitted with commit 96fd35348254dc59b5abe376af6e2ca231519616 by Friedrich W. H. Kossebau to branch master. - Commit Hook On Feb. 29, 2012, 3:38 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104114/ > ----------------------------------------------------------- > > (Updated Feb. 29, 2012, 3:38 a.m.) > > > Review request for Calligra and Jan Hambrecht. > > > Description > ------- > > The flag "indentInside" was not set to "false" on writing <text> and <tspan> > tokens in ArtisticTextShape::saveSvg(...). > That way the created SVG file could contain indenting spaces inside the > <text> and <tspan> tokens, which on reading are interpreted to be spaces > belonging to the text. > > Attached patch fixes that by setting the flag to true (should be switched to > be an enum in some future version, no?). > > > Diffs > ----- > > plugins/artistictextshape/ArtisticTextShape.cpp 301b6c7 > > Diff: http://git.reviewboard.kde.org/r/104114/diff/ > > > Testing > ------- > > Created some artistic text shapes with properties of subtext changed, e.g. > color, to get more tspans in the stored SVG, then loaded and saved the file a > few times. > No longer any spaces are added to the text. > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
