Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-22 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6753 --- When testing with cstester I found that a lot of the test docume

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-22 Thread Thorsten Zachmann
> On Sept. 22, 2011, 8:55 p.m., Jan Hambrecht wrote: > > All in all I think you can commit. However while looking at the code I had > > another idea. If the calculation of the size and the sizeCached member is > > moved to group shape model, we do not have to expose the > > invalidateCacheSize

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-22 Thread C. Boemann
> On Sept. 22, 2011, 8:55 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeContainerModel.cpp, line 41 > > > > > > I am not sure about that. Probably best to check with Caspar if it is > > ok with him. if the propo

Re: Review Request: Fix regression in size of shape groups with a lot of shapes

2011-09-22 Thread Jan Hambrecht
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102645/#review6744 --- Ship it! All in all I think you can commit. However while looki

Re: Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-22 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102679/#review6742 --- In general quite nice. A few remarks, and then i just assumed yo

Review Request: Move several commands from TextTool to the KoTextEditor interface

2011-09-22 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102679/ --- Review request for Calligra. Summary --- KoTextEditor is meant to be

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-22 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6741 --- libs/kotext/KoInlineNote.cpp

Re: Review Request: remove split view functionality

2011-09-22 Thread Boudewijn Rempt
> On July 18, 2011, 3:19 p.m., Sven Langkamp wrote: > > Having two windows side by side introduces lots of other problem: > > -It would bring back the jumping when switching views, because dockers > > would be hidden and shown all the time. > > -You can't have the dockers on one side of the scre

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-22 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/#review6727 --- I have seen some style issues. Please fix them in all your chang

Re: Review Request: Added Footnotes/Endnotes in References Tool

2011-09-22 Thread Brijesh Patel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102552/ --- (Updated Sept. 22, 2011, 12:29 p.m.) Review request for Calligra. Change

Re: news from Debian packaging

2011-09-22 Thread Dag Andersen
Onsdag 21 september 2011 22:18:00 skrev Adrien: > One other thing : > > Maybe you should rename the cmake target of the librcps_plan target > dropping the "lib" prefix, otherwise currently we have a > liblibrcps_plan.so.X. Fixed(soon) Note: while looking for liblib I also found liblibwmf.so -- Mv

Re: news from Debian packaging

2011-09-22 Thread Jaroslaw Staniek
On 22 September 2011 08:44, Boudewijn Rempt wrote: > On Wednesday 21 September 2011 Sep, Jaroslaw Staniek wrote: >> 2011/9/21 Adrien : >> >> >> It's great that you keep us updated! If I may ensure myself you know >> >> it, we're maintaining packaging recommendations in /README.PACKAGERS >> >> file