Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/#review6677 --- This review has been submitted with commit 4c294d9279be9c551c87

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-20 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/#review6675 --- Ship it! - Sebastian On Sept. 20, 2011, 12:29 p.m., C. Boeman

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-20 Thread C. Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/ --- (Updated Sept. 20, 2011, 12:29 p.m.) Review request for Calligra. Change

Re: Calligra akademy mentoring program - call for participation

2011-09-20 Thread Hanna Skott
Hi Calligra developers, I have added Jaroslaw to the list of participants of the Calligra academy. I agree with boemann - there is no reason to get hung-up on the format here :) So far we have the following Calligra academy participants: boud, boemann, ingwa and jstaniek. Are there any mor

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-20 Thread Sebastian Sauer
> On Sept. 20, 2011, 8:59 a.m., Sebastian Sauer wrote: > > words/part/KWOdfWriter.cpp, line 249 > > > > > > Is that correct? I mean we now save it even if the shape is not visible > > on the page (aka the shape mak

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-20 Thread C. Boemann
> On Sept. 20, 2011, 8:59 a.m., Sebastian Sauer wrote: > > words/part/frames/KWFrame.h, line 133 > > > > > > Are you sure it still returns -1 if not defined? > > yes KoTextAnchor defaults to -1 on create and load

Re: Review Request: Store anchor info directly in shapes through a simple userdata like set of methods in KoShape

2011-09-20 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/#review6659 --- libs/kotext/KoTextAnchor.h

Re: Review Request: Fix wrong position calculations in AbstractSelectionStrategy, SelectionStrategy and DragAndDropStrategy

2011-09-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102517/#review6658 --- This review has been submitted with commit ab38a42b294765e696bb

Re: Calligra akademy mentoring program - call for participation

2011-09-20 Thread Jaroslaw Staniek
On 20 September 2011 08:56, Boudewijn Rempt wrote: > On Tuesday 20 September 2011 Sep, Jaroslaw Staniek wrote: >> On 20 September 2011 08:26, Boudewijn Rempt wrote: >> > Note that the url is now         >> > http://community.kde.org/Calligra/Calligra_academy -- like I originally >> > proposed. "