----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102666/#review6675 -----------------------------------------------------------
Ship it! - Sebastian On Sept. 20, 2011, 12:29 p.m., C. Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102666/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2011, 12:29 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Stores a new class KoAnchor on shapes. It's kind of like an extra user data > for applications that support anchoring. > > By having a pointer from the shape to anchoring information lot's of code in > words become easier to maintain. > > Plus we will be able to finally support smart positioning of page anchored > shapes in words > > I tried to keep it out of flake, but since it was impossible to transfer that > data from KoTextLoader to words without going through hoops, and we already > had two methods in KoShape that I could change hold this (in effect void) > pointer I chose the latter. > > Tables will be able to attach it's own variation of anchoring info to KoShape > too by doing it's own subclassing of KoAnchor just like kotext does with > KoTextAnchor > > > Diffs > ----- > > libs/flake/KoShape.h 55f8e97 > libs/flake/KoShape.cpp 1c3fcef > libs/flake/KoShape_p.h d055056 > libs/kotext/KoTextAnchor.h 0819c9b > libs/kotext/KoTextAnchor.cpp f324505 > libs/kotext/opendocument/KoTextLoader.cpp 6ce4695 > libs/kotext/opendocument/KoTextSharedLoadingData.h ddf7fbe > libs/kotext/opendocument/KoTextSharedLoadingData.cpp 6066949 > words/part/KWOdfSharedLoadingData.h 83e6f64 > words/part/KWOdfSharedLoadingData.cpp 1c93e5f > words/part/KWOdfWriter.cpp 4515f6b > words/part/KWRootAreaProvider.cpp 6c30e28 > words/part/frames/KWFrame.h b783c2f > words/part/frames/KWFrame.cpp a8191be > > Diff: http://git.reviewboard.kde.org/r/102666/diff > > > Testing > ------- > > > Thanks, > > C. > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
