Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

> On Aug. 3, 2011, 4:55 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeGroup.cpp, lines 63-76 > > > > > > A group shape can also have filter effects applied, so that must be > > taken into account too. > > And

Re: Review Request: Refactor kotext/KoTableCellStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102200/ --- (Updated Aug. 3, 2011, 8:50 p.m.) Review request for Calligra. Changes -

Re: Review Request: Refactor kotext/KoTableCellStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102200/#review5364 --- Ship it! lots more spaces than the ones i indicated but besides

Re: Review Request: Refactor kotext/KoTableCellStyle

For the record : 1) since these changes imply a lot of tiny changes spread accross kotext/textlayout plus a few tiny extra places, I prefer splitting it in several parts, hence this first step that only provides cleanups and almost get rid of KoTableBorderStyle… 2) the final aim is to be able t

Review Request: Refactor kotext/KoTableCellStyle

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102200/ --- Review request for Calligra. Summary --- First refactoring of KoText

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

> On Aug. 3, 2011, 4:55 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeShadow.cpp, lines 358-361 > > > > > > Where is the number 3 comming from. Shouldn't d->blur be the exact blur > > radius? > > Yue Liu wrote:

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

> On Aug. 3, 2011, 7:40 a.m., Boudewijn Rempt wrote: > > I think the fix to set the size of the group shape simply to zero is wrong. The filter effects can be applied to a group and these need a proper size of a shape to work correctly. - Jan ---

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

> On Aug. 3, 2011, 4:55 p.m., Jan Hambrecht wrote: > > libs/flake/KoShapeShadow.cpp, lines 358-361 > > > > > > Where is the number 3 comming from. Shouldn't d->blur be the exact blur > > radius? I forgot to move t

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5357 --- libs/flake/KoShapeShadow.cpp

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5355 --- libs/flake/KoShapeGroup.cpp

Review Request: GSoC, Stage: Add a tabbar to switch between view modes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102198/ --- Review request for Calligra. Summary --- Add a tabbar to Stage on top

Re: Review Request: Added an undo stack parameter to KoDocument

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102196/#review5348 --- Ship it! libs/main/KoDocument.h

Review Request: Added an undo stack parameter to KoDocument

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102196/ --- Review request for Calligra. Summary --- The clients should be able t

Re: Working with Words...

Just a small note. >  - headers that repeat over page breaks: boemann tells me it's possible > already, but I haven't seen it work yet. That worked for me when I was testing my table hitTest patch recently, at least loading from ODT saved by LO. Don't know if it's possible to insert header rows

Working with Words...

Hi, Some time ago I created a big presentation with Stage and found a bunch of issues. Last week, I actually had occasion to work with Words, and I'd like to share again some of the issues I've found. Some things will be known, but I thought it could be good to focus on them again: * Editing

Re: Review Request: Untangle KoToolSelection and KoTextEditor

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102168/#review5339 --- Ship it! Since no one complained - Casper On Aug. 1, 2011, 9

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5338 --- Ship it! Cool, then I'm fine with shipping it. - Boudewijn O

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

> On Aug. 3, 2011, 7:40 a.m., Boudewijn Rempt wrote: > > libs/flake/KoShapeGroup.cpp, line 63 > > > > > > Please check that this patch doesn't regress on bug 227512 and the > > things described in https://svn.review

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/#review5332 --- libs/flake/KoShapeGroup.cpp

Re: Review Request: Added support for drawing the shadow for a shape group, fixed shadow blur zooming bug.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102072/ --- (Updated Aug. 3, 2011, 7:20 a.m.) Review request for Calligra. Changes -