Re: Review Request: Stage: GSoC: New GUI for manage custom slide shows

2011-07-08 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101820/ --- (Updated July 8, 2011, 8:02 p.m.) Review request for Calligra. Changes -

Re: [calligra/libs-svg-support-jaham] /: let rectangle and ellipse shape save themselves

2011-07-08 Thread jaham
On Thursday 07 July 2011 06:50:05 Thorsten Zachmann wrote: > Hello Jan, > > On Wednesday, July 06, 2011 20:19:29 Jan Hambrecht wrote: > > +class RectangleShape : public KoParameterShape, public SvgSerializable > > I realy think we should avoid using multiple inheritance in each shape that > makes

Re: Questions about Words

2011-07-08 Thread Sebastian Sauer
Aloha Steven, Steven Kakoczky wrote: > I'm trying to understand how words is put together so I can add a Notes > feature to it and was wondering if someone could explain to me what I need > to know about the way the KWView, KWDocument, KWPage, and KWCanvas, or any > related objects, work together

Re: Review Request: nofill and nostroke support in enhanced path from odf

2011-07-08 Thread Lukáš Tvrdý
> On July 8, 2011, 4:05 a.m., Thorsten Zachmann wrote: > > libs/flake/KoSubpath.h, lines 47-48 > > > > > > This break encapsulation. The properties should be moved to a d > > pointer. > > Don't use a pointer fo

Re: Review Request: nofill and nostroke support in enhanced path from odf

2011-07-08 Thread Lukáš Tvrdý
> On July 8, 2011, 4:05 a.m., Thorsten Zachmann wrote: > > libs/flake/KoPathShape.h, lines 178-187 > > > > > > I think these methods should be enhanced to make it possible to > > set/unset the fill/storke of any su

Re: Review Request: nofill and nostroke support in enhanced path from odf

2011-07-08 Thread Lukáš Tvrdý
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101873/ --- (Updated July 8, 2011, 7:02 a.m.) Review request for Calligra, Jan Hambrec