-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101873/
-----------------------------------------------------------
(Updated July 8, 2011, 7:02 a.m.)
Review request for Calligra, Jan Hambrecht and Thorsten Zachmann.
Changes
-------
I forgot to set group to calligra..
So far nice review from Thorsten, I will work on the changes.
Summary
-------
This patch implements S and F commands in draw:enhanced-path. So far there were
no support for this.
The idea is that the path is now rendered per sub-path, because S (no stroke)
and F (no fill) can be
specified per subpath in the draw:enhanced-path.
I changed typedef KoSubpath to standalone class as it needs attributes about no
fill and no stroke.
I moved the code that operates only on KoSubpath to that class from KoPathShape.
Then I render the output per QPainterPath with appropriate attributes (I turn
off the pen temporary if no stroke and turn of the brush if no fill)
This addresses bug 239561.
http://bugs.kde.org/show_bug.cgi?id=239561
Diffs
-----
libs/flake/CMakeLists.txt b9f388f
libs/flake/KoConnectionShape.cpp 210e171
libs/flake/KoPathShape.h 8b54f26
libs/flake/KoPathShape.cpp da6c928
libs/flake/KoPathShape_p.h e1e2843
libs/flake/KoSubpath.h PRE-CREATION
libs/flake/KoSubpath.cpp PRE-CREATION
libs/flake/commands/KoParameterToPathCommand.cpp 177d35d
libs/flake/commands/KoSubpathRemoveCommand.cpp 79894f0
plugins/pathshapes/ellipse/EllipseShape.cpp 0576f5d
plugins/pathshapes/enhancedpath/EnhancedPathCommand.cpp a58d67e
plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 46d76de
plugins/pathshapes/rectangle/RectangleShape.cpp 9caca45
plugins/pathshapes/star/StarShape.cpp 5fc8562
Diff: http://git.reviewboard.kde.org/r/101873/diff
Testing
-------
>From bug 239561:
a) before patch http://wstaw.org/m/2011/07/07/nofill_nostroke_example_before.png
b) with my patch http://wstaw.org/m/2011/07/07/nofill_nostroke_example_after.png
I first managed to break several unit tests (TestPointMergeCommand and
TestPathShape),
but I fixed all the problems and no tests are broken by this patch now.
Thanks,
Lukáš
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
