Re: Review Request: one memory leak, 7 exceptions and two comparations.

2011-06-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101730/#review4086 --- This review has been submitted with commit c3b4926dce11703f7517

Re: Review Request: one memory leak, 7 exceptions and two comparations.

2011-06-22 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101730/#review4085 --- Ship it! Thanks for the patch. I have added some comments. Plea

Re: Trying to review Calligra

2011-06-22 Thread Thorsten Zachmann
On Thursday, June 23, 2011 02:12:52 Jesse Smith wrote: > Hello Calligra developers, > > I'm writing for two reasons. First up, I'm hoping to do a review of > Calligra to let the open source community know more about your work. And > second I'm having some trouble getting Calligra installed. I'm ru

Trying to review Calligra

2011-06-22 Thread Jesse Smith
Hello Calligra developers, I'm writing for two reasons. First up, I'm hoping to do a review of Calligra to let the open source community know more about your work. And second I'm having some trouble getting Calligra installed. I'm running Ubuntu (10.04) and the instructions on your website for ins

Review Request: one memory leak, 7 exceptions and two comparations.

2011-06-22 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101730/ --- Review request for Calligra. Summary --- The two comparations are obv

Re: best unittest result ever:

2011-06-22 Thread Marijn Kruisselbrink
On Wednesday, June 22, 2011 02:32:21 pm Jos van den Oever wrote: > On Wednesday, June 22, 2011 23:25:55 PM Jos van den Oever wrote: > > On Wednesday, June 22, 2011 23:13:40 PM Jos van den Oever wrote: > > > On Wednesday, June 22, 2011 14:51:52 PM Cyrille Berger Skott wrote: > > > > On Wednesday 22

Re: best unittest result ever:

2011-06-22 Thread Jos van den Oever
On Wednesday, June 22, 2011 23:25:55 PM Jos van den Oever wrote: > On Wednesday, June 22, 2011 23:13:40 PM Jos van den Oever wrote: > > On Wednesday, June 22, 2011 14:51:52 PM Cyrille Berger Skott wrote: > > > On Wednesday 22 June 2011, Boudewijn Rempt wrote: > > > > On Wednesday 22 June 2011 Jun,

Re: best unittest result ever:

2011-06-22 Thread Jos van den Oever
On Wednesday, June 22, 2011 23:13:40 PM Jos van den Oever wrote: > On Wednesday, June 22, 2011 14:51:52 PM Cyrille Berger Skott wrote: > > On Wednesday 22 June 2011, Boudewijn Rempt wrote: > > > On Wednesday 22 June 2011 Jun, Cyrille Berger Skott wrote: > > > > > while on Jos' nameless build > > >

Re: best unittest result ever:

2011-06-22 Thread Jos van den Oever
On Wednesday, June 22, 2011 14:51:52 PM Cyrille Berger Skott wrote: > On Wednesday 22 June 2011, Boudewijn Rempt wrote: > > On Wednesday 22 June 2011 Jun, Cyrille Berger Skott wrote: > > > > while on Jos' nameless build > > > > server, many krita/pigment tests fail for some weird reason (they > > >

Re: best unittest result ever:

2011-06-22 Thread Cyrille Berger Skott
On Wednesday 22 June 2011, Boudewijn Rempt wrote: > On Wednesday 22 June 2011 Jun, Cyrille Berger Skott wrote: > > > while on Jos' nameless build > > > server, many krita/pigment tests fail for some weird reason (they > > > shouldn't be enabled at all there, actually). > > > > I guess some depende

Re: best unittest result ever:

2011-06-22 Thread Boudewijn Rempt
On Wednesday 22 June 2011 Jun, Cyrille Berger Skott wrote: > > while on Jos' nameless build > > server, many krita/pigment tests fail for some weird reason (they > > shouldn't be enabled at all there, actually). > I guess some dependencies check are not working correctly. What is the > missing >

Re: best unittest result ever:

2011-06-22 Thread Cyrille Berger Skott
In any case great work :) On Tuesday 21 June 2011, Boudewijn Rempt wrote: > Locally, I've only got these failures: > > The following tests FAILED: > 23 - kspread-Formula (Failed) > 197 - libs-kotext-styles-TestOpenDocumentStyle (Failed) > 199 - kotext-odf-TestLoading (Fai

2.4 release schedule

2011-06-22 Thread Cyrille Berger Skott
Hi, I am proposing the following release schedule: July 13th -> soft-freeze, all features need to be noted down in the feature plan August 31th -> hard freeze, no more features in master September 7th -> beta1 is tagged, master is branched into "