----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101730/#review4086 -----------------------------------------------------------
This review has been submitted with commit c3b4926dce11703f75175a0dab2339e5814f9d68 by Jaime Torres to branch master. - Commit On June 22, 2011, 9:46 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101730/ > ----------------------------------------------------------- > > (Updated June 22, 2011, 9:46 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > The two comparations are obvious. > The memory leak, I think Qt will not delete them. > The exceptions, following C++ style guides, the variable is preferred by > reference. > > > Diffs > ----- > > filters/karbon/applixgraphics/applixgraphicimport.cc e8407fd > filters/kpresenter/powerpoint/ParsedPresentation.cpp 0f375b9 > filters/libmso/ODrawToOdf.cpp 6551a62 > filters/tables/excel/sidewinder/format.h e744a1c > > Diff: http://git.reviewboard.kde.org/r/101730/diff > > > Testing > ------- > > > Thanks, > > Jaime Torres > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
