Re: Double^W Quadruple speed parsing of binary MS Office files

2011-06-15 Thread Boudewijn Rempt
On Thursday 16 June 2011 Jun, Sebastian Sauer wrote: > On Tuesday 14 June 2011 09:19:20 Jos van den Oever wrote: > > On Monday, June 13, 2011 19:02:09 PM Jos van den Oever wrote: > > > When run on a set of 600 ppt files from a.o. kofficetests, this is the > > > output from valgrind: > > > simpletes

Re: words crash, help needed

2011-06-15 Thread Sebastian Sauer
On Thursday 16 June 2011 02:19:04 C. Boemann wrote: > On Thursday 16 June 2011 01:58:42 Sebastian Sauer wrote: > > On Wednesday 15 June 2011 15:16:44 Dag Andersen wrote: > > > Onsdag 15 juni 2011 15:00:33 skrev Sebastian Sauer: > > > > Seems meanwhile I found the reason why it crashes thanks to you

Re: Double^W Quadruple speed parsing of binary MS Office files

2011-06-15 Thread Sebastian Sauer
On Tuesday 14 June 2011 09:19:20 Jos van den Oever wrote: > On Monday, June 13, 2011 19:02:09 PM Jos van den Oever wrote: > > When run on a set of 600 ppt files from a.o. kofficetests, this is the > > output from valgrind: > > simpletest: (normal run time: 5.7 seconds) > > ==28930== total heap us

Re: words crash, help needed

2011-06-15 Thread C. Boemann
On Thursday 16 June 2011 01:58:42 Sebastian Sauer wrote: > On Wednesday 15 June 2011 15:16:44 Dag Andersen wrote: > > Onsdag 15 juni 2011 15:00:33 skrev Sebastian Sauer: > > > Seems meanwhile I found the reason why it crashes thanks to your hint > > > :) The fix is at http://pastebin.com/fsNFBwqY a

Re: Review Request: Proper handle break-after="page"

2011-06-15 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101631/#review3918 --- Ship it! looks ok to me - Casper On June 15, 2011, 4:16 p.m.

Re: words crash, help needed

2011-06-15 Thread Sebastian Sauer
On Wednesday 15 June 2011 15:16:44 Dag Andersen wrote: > Onsdag 15 juni 2011 15:00:33 skrev Sebastian Sauer: > > Seems meanwhile I found the reason why it crashes thanks to your hint :) > > The fix is at http://pastebin.com/fsNFBwqY and the reason was that even > > when the line wasn't fitting (cau

Re: Review Request: Proper handle break-after="page"

2011-06-15 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101631/ --- (Updated June 15, 2011, 4:16 p.m.) Review request for Calligra. Summary

Re: Review Request: Proper handle break-after="page"

2011-06-15 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101631/ --- (Updated June 15, 2011, 4:15 p.m.) Review request for Calligra. Summary

Review Request: Proper handle break-after="page"

2011-06-15 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101631/ --- Review request for Calligra. Summary --- The problem is that incremen

Re: words crash, help needed

2011-06-15 Thread Dag Andersen
Onsdag 15 juni 2011 15:00:33 skrev Sebastian Sauer: > Seems meanwhile I found the reason why it crashes thanks to your hint :) > The fix is at http://pastebin.com/fsNFBwqY and the reason was that even > when the line wasn't fitting (cause it had a width of zero for example) we > still added one cha

Re: words crash, help needed

2011-06-15 Thread Sebastian Sauer
Seems meanwhile I found the reason why it crashes thanks to your hint :) The fix is at http://pastebin.com/fsNFBwqY and the reason was that even when the line wasn't fitting (cause it had a width of zero for example) we still added one character to it. Will test a bit more, add an infinite loop

Re: words crash, help needed

2011-06-15 Thread Sebastian Sauer
Dag Andersen wrote: > I'm looking into a crash which happens when textshapes is edited and the > shape is not on page 1. This is a general case of header/footer crash > reported in: https://bugs.kde.org/show_bug.cgi?id=273945 > > AFAICS the problem is in KWRootAreaProvider::provide(). > It seems

Re: Renaming, cont'd

2011-06-15 Thread Boudewijn Rempt
On Wednesday 15 June 2011 Jun, Jaroslaw Staniek wrote: > Hi, > Is it good time to replace KIconLoader::global()->addAppDir("koffice") > with KIconLoader::global()->addAppDir("calligra")? > We already switched to KGlobal::locale()->insertCatalog("calligra") for i18n. That's part of my patch, but I

Re: Renaming, cont'd

2011-06-15 Thread Cyrille Berger Skott
On Wednesday 15 Jun 2011, Jaroslaw Staniek wrote: > Hi, > Is it good time to replace KIconLoader::global()->addAppDir("koffice") > with KIconLoader::global()->addAppDir("calligra")? > We already switched to KGlobal::locale()->insertCatalog("calligra") for > i18n. sure, make sure the icons installat

words crash, help needed

2011-06-15 Thread Dag Andersen
I'm looking into a crash which happens when textshapes is edited and the shape is not on page 1. This is a general case of header/footer crash reported in: https://bugs.kde.org/show_bug.cgi?id=273945 AFAICS the problem is in KWRootAreaProvider::provide(). It seems to mix up which page number to u

Renaming, cont'd

2011-06-15 Thread Jaroslaw Staniek
Hi, Is it good time to replace KIconLoader::global()->addAppDir("koffice") with KIconLoader::global()->addAppDir("calligra")? We already switched to KGlobal::locale()->insertCatalog("calligra") for i18n. -- regards / pozdrawiam, Jaroslaw Staniek  http://www.linkedin.com/in/jstaniek  Kexi & Callig