Re: Review Request: Anchored shape positioning fix

2011-06-07 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101532/#review3759 --- When testing the patch some random files I found one problem. L

Re: Review Request: GSoC: improve selection, drag&drop of Stage Slides Sorter

2011-06-07 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101501/ --- (Updated June 7, 2011, 8:42 p.m.) Review request for Calligra. Changes -

review-request: Fix objects are displayed if they should be hidden

2011-06-07 Thread Sebastian Sauer
This is related to bug https://bugs.kde.org/show_bug.cgi?id=274905 or to be more exact to the objects displayed at the top of the first page which should not be displayed. The problem: The anchored objects are anchored to a header/footer which is never created and displayed cause no page with s

Re: Review Request: changes to the doc dir in calligra

2011-06-07 Thread Boudewijn Rempt
On Tuesday 07 June 2011 Jun, Casper Boemann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101529/#review3743 > --- > >

Re: Review Request: Anchored shape positioning fix

2011-06-07 Thread Sebastian Sauer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101532/#review3747 --- Ship it! More testing done and it indeed looks correct and I di

Re: Review Request: Anchored shape positioning fix

2011-06-07 Thread Sebastian Sauer
> On June 7, 2011, 1:17 p.m., Casper Boemann wrote: > > Thanks for working on this. I'm no totally against it, but just a bit > > worried it's a gainst the odf spec, so I'm going to have to take a closer > > look. > > > > > > > > I think it's good, but as i said i really neeed to look this

Re: Review Request: changes to the doc dir in calligra

2011-06-07 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101529/#review3743 --- this sounds beneign enough to me to not evn require a review. I'

Re: Review Request: Anchored shape positioning fix

2011-06-07 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101532/#review3742 --- Thanks for working on this. I'm no totally against it, but just

Re: Review Request: KoUnavailShape should show background fill

2011-06-07 Thread Matus Hanzes
> On June 6, 2011, 1:29 p.m., Thorsten Zachmann wrote: > > Would it be possible to see a document showing the problem? > > > > Also I think if the frame is empty it might be a bad idea for the unavail > > shape to pick it up or to display something. However you fix seams to do > > something e

Review Request: Anchored shape positioning fix

2011-06-07 Thread Matus Hanzes
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101532/ --- Review request for Calligra, Casper Boemann and Sebastian Sauer. Summary -