> On June 6, 2011, 1:29 p.m., Thorsten Zachmann wrote:
> > Would it be possible to see a document showing the problem? 
> > 
> > Also I think if the frame is empty it might be a bad idea for the unavail 
> > shape to pick it up or to display something. However you fix seams to do 
> > something else and is nowhere checking if there is content or not.
> >

http://valdyas.org/~lukast/a.odt


- Matus


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101517/#review3720
-----------------------------------------------------------


On June 6, 2011, 8:40 a.m., Matus Hanzes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101517/
> -----------------------------------------------------------
> 
> (Updated June 6, 2011, 8:40 a.m.)
> 
> 
> Review request for Calligra, Boudewijn Rempt, Thorsten Zachmann, and Inge 
> Wallin.
> 
> 
> Summary
> -------
> 
> If there is empty frame in odt file calligra engine creates KoUnavailShape.
> 
> KoUnavailShape shows only question mark.
> I think it would be better to show background filling instead of question 
> mark if there is some.
> 
> 
> Diffs
> -----
> 
>   libs/flake/KoUnavailShape.cpp 7f806d7 
> 
> Diff: http://git.reviewboard.kde.org/r/101517/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matus
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to