Re: Review Request: Fix conflicting tool actions

2011-06-03 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101468/#review3661 --- Ship it! sure, let's see how it plays out, and i'll tell if it

Review Request: GSoC: improve selection, drag&drop of Stage Slides Sorter

2011-06-03 Thread Paul Mendez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101501/ --- Review request for Calligra. Summary --- Add +/- buttons for selectio

Re: Review Request: Fix conflicting tool actions

2011-06-03 Thread Thorsten Zachmann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101468/#review3660 --- Ship it! I think the patch should be committed as it fixes a ve

Some opinion.

2011-06-03 Thread Helder Cesar
Hi folks. I posted now about some ideas about the stencil creation on Calligra (Flow), I really like some opinions. The link is: https://helderc.wordpress.com/2011/06/03/some-ideas-about-stencil-creation/ Thanks a lot! -- *Helder C. R. de Oliveira *http://helderc.co.nr* * __

Re: Review Request: Fix conflicting tool actions

2011-06-03 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101468/#review3658 --- I'm a bit sceptical as i have some shurtcut that i really want t

Re: Review Request: Fixes 274118 and couple of other fixes

2011-06-03 Thread Casper Boemann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101500/#review3657 --- It seems okay, but i'm way too tired and exhusted to make a real

Re: Review-request: Fix infinite loop caused by variable-refresh

2011-06-03 Thread C. Boemann
On Friday 03 June 2011 22:09:38 Sebastian Sauer wrote: > C. Boemann wrote: > > On Friday 03 June 2011 21:13:59 Sebastian Sauer wrote: > >> Hi, > >> > >> attached patch fixes the infinite loop with the document attached to > >> comment #3 in https://bugs.kde.org/show_bug.cgi?id=260219 . > >> > >>

Re: Fwd: [calligra] libs/kotext/styles: Use QTextLength for paragraph margins

2011-06-03 Thread Pierre
On Friday 03 June 2011 22:54:02 Cyrille Berger Skott wrote: > On Friday 03 June 2011, Pierre wrote: > > > TestBlockLayout: > > > http://my.cdash.org/testDetails.php?test=6288300&build=194054 > > > > Hum, fixed part one, I'm not sure about the second part... > > I suppose it wasn't failing previous

Re: Fwd: [calligra] libs/kotext/styles: Use QTextLength for paragraph margins

2011-06-03 Thread Cyrille Berger Skott
On Friday 03 June 2011, Pierre wrote: > > TestBlockLayout: > > http://my.cdash.org/testDetails.php?test=6288300&build=194054 > > Hum, fixed part one, I'm not sure about the second part... > I suppose it wasn't failing previously It was working before. Is the test passing for you ? -- Cyrille Be

Re: Fwd: [calligra] libs/kotext/styles: Use QTextLength for paragraph margins

2011-06-03 Thread Pierre
On Friday 03 June 2011 15:00:41 Cyrille Berger Skott wrote: > Hi, Hi Thanks for your report. > > I think it is causing failures in TestBlockLayout and TestStyles: > > TestBlockLayout: > http://my.cdash.org/testDetails.php?test=6288300&build=194054 Hum, fixed part one, I'm not sure about the sec

Review Request: Fixes 274118 and couple of other fixes

2011-06-03 Thread Gopalakrishna Bhat
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101500/ --- Review request for Calligra and Casper Boemann. Summary --- This fixe

Re: Review-request: Fix infinite loop caused by variable-refresh

2011-06-03 Thread Sebastian Sauer
C. Boemann wrote: > On Friday 03 June 2011 21:13:59 Sebastian Sauer wrote: >> Hi, >> >> attached patch fixes the infinite loop with the document attached to >> comment #3 in https://bugs.kde.org/show_bug.cgi?id=260219 . >> >> The idea is to not include the previous and next root-areas and mark th

Re: Review-request: Fix infinite loop caused by variable-refresh

2011-06-03 Thread C. Boemann
On Friday 03 June 2011 21:13:59 Sebastian Sauer wrote: > Hi, > > attached patch fixes the infinite loop with the document attached to > comment #3 in https://bugs.kde.org/show_bug.cgi?id=260219 . > > The idea is to not include the previous and next root-areas and mark them > dirty if charsAdded a

Review-request: Fix infinite loop caused by variable-refresh

2011-06-03 Thread Sebastian Sauer
Hi, attached patch fixes the infinite loop with the document attached to comment #3 in https://bugs.kde.org/show_bug.cgi?id=260219 . The idea is to not include the previous and next root-areas and mark them dirty if charsAdded and charsRemoved ==0 what means no characters where changed. In suc

Re: Fwd: [calligra] libs/kotext/styles: Use QTextLength for paragraph margins

2011-06-03 Thread Thorsten Zachmann
Hello Pierre, > Because of the following commit, regressions may happen in text layout. I > did the needed changes to keep everything compiling, I did fixes in > libs/textlayout to make sure it uses the proper values (btw, using > QTextFormat is not enough, it's much better to just use "our" class

Re: Fwd: [calligra] libs/kotext/styles: Use QTextLength for paragraph margins

2011-06-03 Thread Cyrille Berger Skott
Hi, I think it is causing failures in TestBlockLayout and TestStyles: TestBlockLayout: http://my.cdash.org/testDetails.php?test=6288300&build=194054 TestStyles: http://my.cdash.org/testDetails.php?test=6280021&build=194054 On Thursday 02 June 2011, Pierre wrote: > Hi > > Because of the follo