----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101468/#review3660 -----------------------------------------------------------
Ship it! I think the patch should be committed as it fixes a very big annoyance like the following error message when pressing Ctrl+A in the text shape. The key sequence 'Ctrl+A' is ambiguous. Use 'Configure Shortcuts' from the 'Settings' menu to solve the ambiguity. No action will be triggered. @Casper can you please explain what kind of shortcuts you want to be active event the tool is not active. Please note that is already possible to have actions in the view that are also active when the tool is not active. And that is the problem Jan is fixing with this patch. It is just that with this patch the shortcut of the tool overwrites the shortcut of the view which is needed as it fixes the above shown error message. If there is a need for shortcuts in the application that can't be overwritten by tools that is a new feature which can be added later if that is wanted by someone. However as the shortcuts are not working at all currently if a tool overwrites them and the user gets a very annoying error message I think this patch should be committed as it improves the current situation. - Thorsten On May 29, 2011, 10:17 a.m., Jan Hambrecht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101468/ > ----------------------------------------------------------- > > (Updated May 29, 2011, 10:17 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > At them moment there is a problem with actions from tools which duplicate > standard actions in applications. An example are select all /deselect > standard actions. There are calligra applications which create these in their > view classes to have support to select/deselect shapes. However some tools > like the text tool do have these actions too. > When for instance the text tool gets activated, all its actions are enabled > which causes the select all action conflict with that of the application > (they have the same standard shortcut). > This patch fixes that as it will disable any action from the application > during the activation of the tool with an conflicting action. When disabling > the tool again, the application action is enabled again. > That way selecting all works in the text tool again and I could add working > support for select all/deselect in the artistic text tool too. > > > Diffs > ----- > > libs/flake/KoToolManager.cpp bf68ad9 > libs/flake/KoToolManager_p.h 83ea4de > plugins/artistictextshape/ArtisticTextTool.h e9b6347 > plugins/artistictextshape/ArtisticTextTool.cpp 68debef > plugins/textshape/TextTool.cpp b95e18e > words/part/words.rc c4aa3f7 > words/part/words_readonly.rc b4abb2a > > Diff: http://git.reviewboard.kde.org/r/101468/diff > > > Testing > ------- > > Tested with the text tool, artistic text tool in karbon and stage. > > > Thanks, > > Jan > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
