Re: Questions about shape group

Hello, Found that 5 years ago Thomas Zander moved KoShapeGroup::boundingRect() to KoCommand, which now becomes KoShapeGroupCommandPrivate::containerBoundingRect(). I think now it's ok to move it back to KoShapeGroup, what do you think? https://projects.kde.org/projects/calligra/repository/revisio

Re: Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

> On May 3, 2011, 4:17 a.m., Thorsten Zachmann wrote: > > Can the code for checking the mimetype be moved to the KoFilterManager? The > > no extension of the API would be needed. Looks like I published to fast. Also the code does more belong to the KoFilterManager then to KoDocument. It might

Re: Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101271/#review3082 --- Can the code for checking the mimetype be moved to the KoFilterM

Re: Questions about shape group

On Thursday 28 April 2011 18:02:34 you wrote: > Also, I noticed that shadow.Insets is considered when calculating the > boundingRect to a shape, is it needed to include the shadow into the > boundingRect? And besides calculating boundingRect, where is shadow.Insets > being used? Yes the shadow ins

Re: Questions about shape group

On Thursday 28 April 2011 16:52:17 you wrote: > Hello Jan, > > Should group be redesigned to be a shape (actually I still don't understand > why group inherits shape container and shape container inherits koShape but > group is not a shape) ? Well you already found the correct answer. :-) KoShap

Re: Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

> On May 2, 2011, 2:55 p.m., David Faure wrote: > > Well, if it works I still think there's some cleanups to be done at > > some point, some extension checks are redundant. I checked the extension checks. I do agree that it's very strange that they are needed. It looks as if they would b

Re: Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101271/#review3061 --- Ship it! Well, if it works I still think there's some clean

Re: Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

> On May 2, 2011, 1:38 p.m., David Faure wrote: > > Such hardcoded lists of mimetypes and extensions make me cringe :) > > > > Did you first check what KMimeType::findByContent returns? Surely in many > > cases it can help, when findByUrl is fooled by a wrong extension. > > Althought, it might

Re: Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

> On May 2, 2011, 1:40 p.m., David Faure wrote: > > libs/main/KoDocument.cpp, line 1396 > > > > > > Oh, I hadn't seen that the list includes the result of > > "findByFileContents" already. > > > > > >

Re: Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101271/#review3057 --- libs/main/KoDocument.cpp

Re: Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101271/ --- (Updated May 2, 2011, 1:40 p.m.) Review request for Calligra and David Fau

Re: Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101271/#review3056 --- Such hardcoded lists of mimetypes and extensions make me cringe

Re: Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101271/#review3053 --- libs/main/KoFilterManager.h

Review Request: Make Calligra able to load foo.doc that really contains a docx file, and similar for xls and ppt.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101271/ --- Review request for Calligra. Summary --- Lately, a lot of document ha