> On May 2, 2011, 2:55 p.m., David Faure wrote:
> > Well, if it works.... I still think there's some cleanups to be done at
> > some point, some extension checks are redundant.
I checked the extension checks. I do agree that it's very strange that they
are needed. It looks as if they would be totally unneeded, but in practice
sometimes openFile() is called with a mimetype like "application/zip". Could
this be a bug in KParts::ReadWritePart? I have to admit that I'm very unsure
about how the call chain goes here. Do you think I should remove this call:
QString typeName = arguments().mimeType();
That is the source of the too unspecific mimetypes.
- Inge
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101271/#review3061
-----------------------------------------------------------
On May 2, 2011, 1:40 p.m., Inge Wallin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101271/
> -----------------------------------------------------------
>
> (Updated May 2, 2011, 1:40 p.m.)
>
>
> Review request for Calligra and David Faure.
>
>
> Summary
> -------
>
> Lately, a lot of document has been cropping up that have names like foo.doc
> but that really are docx files inside. Similar goes for xls/xlsx and
> ppt/pptx. This patch handles this case by not just using the name for
> determining the mimetype of the file while loading, but also looking at the
> contents (KMimeType:findByContents). It also introduces a replacement scheme
> to take care of reported mimetypes like application/zip instead of, say, docx.
>
>
> Diffs
> -----
>
> krita/plugins/filters/fastcolortransfer/fastcolortransfer.cpp fc94465
> krita/sdk/tests/filestest.h ef6f0f0
> krita/ui/kis_import_catcher.cc 8c2c42a
> libs/main/KoDocument.cpp 1ed2052
> libs/main/KoFilterManager.h fc7731c
> libs/main/KoFilterManager.cpp f840f69
>
> Diff: http://git.reviewboard.kde.org/r/101271/diff
>
>
> Testing
> -------
>
> This patch is tested on all combinations of doc/docx, ppt/pptx and xls/xlsx
> as well as on files containing the actual format that the names suggest.
>
>
> Thanks,
>
> Inge
>
>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
