Re: Review Request: Patch for using KoAbstractionController directly from FreOffice

2011-02-09 Thread Jaroslaw Staniek
FYI The refactoring is mostly done (compiles), so now it'll be tested. http://community.kde.org/Calligra/Libs/KoAbstraction#Refactoring -- regards / pozdrawiam, Jaroslaw Staniek  http://www.linkedin.com/in/jstaniek  Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org)  KDE Softw

Re: GSoC 2011!

2011-02-09 Thread C. Boemann
On Wednesday 09 February 2011 16:11:41 todd rme wrote: > On Wed, Feb 9, 2011 at 3:50 AM, C. Boemann wrote: > > On Wednesday 09 February 2011 09:39:28 Boudewijn Rempt wrote: > >> On Wednesday 09 February 2011, todd rme wrote: > >> > I have a couple suggestions about possible projects: > >> ... > >>

Re: GSoC 2011!

2011-02-09 Thread todd rme
On Wed, Feb 9, 2011 at 3:50 AM, C. Boemann wrote: > On Wednesday 09 February 2011 09:39:28 Boudewijn Rempt wrote: >> On Wednesday 09 February 2011, todd rme wrote: >> > I have a couple suggestions about possible projects: >> ... >> >> I think these are pretty cool ideas! Have you added them to >>

Re: GSoC 2011!

2011-02-09 Thread todd rme
On Wed, Feb 9, 2011 at 3:39 AM, Boudewijn Rempt wrote: > On Wednesday 09 February 2011, todd rme wrote: >> I have a couple suggestions about possible projects: > > ... > > I think these are pretty cool ideas! Have you added them to > http://community.kde.org/GSoC/2011/Ideas? I could do so, but a

Re: Review Request: Limit zooming to a minimum and maximum zoom value

2011-02-09 Thread Arjen Hiemstra
> On Feb. 9, 2011, 9:25 a.m., Marijn Kruisselbrink wrote: > > libs/widgets/KoZoomMode.cpp, lines 32-33 > > > > > > Maybe keep the default values to those that are currently used by > > KoZoomAction? thus 0.0625 - 16

Re: Review Request: Limit zooming to a minimum and maximum zoom value

2011-02-09 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100613/#review1325 --- libs/widgets/KoZoomAction.cpp

Re: Review Request: Limit zooming to a minimum and maximum zoom value

2011-02-09 Thread Marijn Kruisselbrink
Hmm, that didn't quite work as intended, I tried to add another comment: "Or probably even something that doesn't hardcode the center to 1, but just interpolates the entire range..." But apparently reviewboard doesn't want me to actually publish that one... Marijn

Re: Review Request: Limit zooming to a minimum and maximum zoom value

2011-02-09 Thread Marijn Kruisselbrink
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100613/#review1322 --- - Marijn On Feb. 9, 2011, 12:45 a.m., Arjen Hiemstra wrote: >

Re: Review Request: Limit zooming to a minimum and maximum zoom value

2011-02-09 Thread Marijn Kruisselbrink
> On Feb. 9, 2011, 9:25 a.m., Marijn Kruisselbrink wrote: > > libs/widgets/KoZoomAction.cpp, lines 78-85 > > > > > > I'm not entirely sure, but doesn't this change the zoom levels from > > being exponential (1.25, 2.5

Re: Review Request: Limit zooming to a minimum and maximum zoom value

2011-02-09 Thread Marijn Kruisselbrink
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100613/#review1319 --- libs/widgets/KoZoomAction.cpp

Re: GSoC 2011!

2011-02-09 Thread C. Boemann
On Wednesday 09 February 2011 09:39:28 Boudewijn Rempt wrote: > On Wednesday 09 February 2011, todd rme wrote: > > I have a couple suggestions about possible projects: > ... > > I think these are pretty cool ideas! Have you added them to > http://community.kde.org/GSoC/2011/Ideas? i'v merged in th

Re: GSoC 2011!

2011-02-09 Thread Boudewijn Rempt
On Wednesday 09 February 2011, todd rme wrote: > I have a couple suggestions about possible projects: ... I think these are pretty cool ideas! Have you added them to http://community.kde.org/GSoC/2011/Ideas? -- Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org

Re: Review Request: Limit zooming to a minimum and maximum zoom value

2011-02-09 Thread Boudewijn Rempt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100613/#review1318 --- Good stuff, but please make sure the unittest passes before merg