[RFC PATCH 3/3] File used to test things

2024-11-11 Thread Britton Leo Kerin
--- src/Makefile.test_per_target_oneshell | 13 + 1 file changed, 13 insertions(+) create mode 100644 src/Makefile.test_per_target_oneshell diff --git a/src/Makefile.test_per_target_oneshell b/src/Makefile.test_per_target_oneshell new file mode 100644 index ..52980595 --- /d

[bug #65323] Functions/shell test 22 causes ksh to crash.

2024-05-06 Thread Paul D. Smith
Update of bug #65323 (group make): Status:None => Fixed Open/Closed:Open => Closed Operating System:None => POSIX-Based Fixed Release:

[bug #65596] Test for let function not available in .FEATURES

2024-04-21 Thread Paul D. Smith
Update of bug #65596 (group make): Status:None => Wont Fix Open/Closed:Open => Closed ___ Follow-up Comment #3: As Dmitry mentions most

[bug #65596] Test for let function not available in .FEATURES

2024-04-17 Thread Dmitry Goncharov
Follow-up Comment #2, bug #65596 (group make): Other functions are not present in .FEATURES as well. There is really only guile. ___ Reply to this item at:

[bug #65596] Test for let function not available in .FEATURES

2024-04-16 Thread Jouke Witteveen
Follow-up Comment #1, bug #65596 (group make): You're right. I guess it's too late to fix that now, since it will not be fixed in all releases that have the "let" function. You can test for its presence with the following construct: $(filter builtin,$(foreach let,un

[bug #65596] Test for let function not available in .FEATURES

2024-04-15 Thread anonymous
URL: <https://savannah.gnu.org/bugs/?65596> Summary: Test for let function not available in .FEATURES Group: make Submitter: None Submitted: Mon 15 Apr 2024 07:08:37 PM UTC Severity: 3 - Normal

Re: [PATCH] Fix integer overflow test in parse_int

2024-03-28 Thread Paul Smith
On Sun, 2024-01-07 at 16:09 -0800, Paul Eggert wrote: > * src/arscan.c (parse_int): Use intprops.h macros rather than trying > to detect integer overflow by hand, and doing it incorrectly. > Here is an example of why the old code was incorrect. > If val == 3689348814741910323, base == 10, *ptr == '

[bug #65323] Functions/shell test 22 causes ksh to crash.

2024-02-16 Thread Dmitry Goncharov
Additional Item Attachment, bug#65323 (group make): File name: sv65323.diff Size:0 KB AGPL NOTICE These attachments are served by Savane. You can download the corresponding source code of Savane at https:/

[bug #65323] Functions/shell test 22 causes ksh to crash.

2024-02-16 Thread Dmitry Goncharov
Follow-up Comment #1, bug#65323 (group make): functions/shell/t022.mk crashes certain shells. E.g. when ksh is used as /bin/sh. That's the test with make exporting a variable whos name is 40K characters long. I tried using perl as a shell, but perl exits with an error message. The patch i

[bug #65323] Functions/shell test 22 causes ksh to crash.

2024-02-16 Thread Dmitry Goncharov
URL: <https://savannah.gnu.org/bugs/?65323> Summary: Functions/shell test 22 causes ksh to crash. Group: make Submitter: dgoncharov Submitted: Sat 17 Feb 2024 02:50:44 AM UTC Severity: 3 -

[bug #63852] Two test failure running the test suite as root

2024-02-04 Thread Paul D. Smith
Update of bug#63852 (group make): Item Group:None => Build/Install ___ Reply to this item at: ___ Message se

Re: [PATCH] Fix integer overflow test in parse_int

2024-01-07 Thread John Reiser
ar + || INT_MULTIPLY_WRAPV (val, base, &val) + || INT_ADD_WRAPV (val, *ptr - '0', &val) The patch is correct, but there is an opportunity to understand _why_ the old code is incorrect. The test "result < input", here (nv < val), is a correct test for

[PATCH] Fix integer overflow test in parse_int

2024-01-07 Thread Paul Eggert
* src/arscan.c (parse_int): Use intprops.h macros rather than trying to detect integer overflow by hand, and doing it incorrectly. Here is an example of why the old code was incorrect. If val == 3689348814741910323, base == 10, *ptr == '0', UINTMAX_WIDTH == 64, then (val * base) + (*ptr - '0') yiel

Re: make-4.3 on Linux x86_64 fails features/output-sync test

2023-11-27 Thread Paul Smith
On Mon, 2023-11-27 at 15:27 -0500, Dennis Clarke via Bug reports and discussion for GNU make wrote: > GNU Make 4.3 Is the failure repeatable? Have you tried it with the latest version of GNU Make? It certainly doesn't fail on my system (which is, obviously, also running x86_64 GNU/Linux). But, t

make-4.3 on Linux x86_64 fails features/output-sync test

2023-11-27 Thread Dennis Clarke via Bug reports and discussion for GNU make
This is highly unexpected on a plain jane Linux x86_64 type box : -- Running tests for GNU make on Linux esther 6.1.63-genunix x86_64 GNU Make 4.3 ---

[bug #63852] Two test failure running the test suite as root

2023-03-01 Thread Paul D. Smith
Follow-up Comment #1, bug #63852 (project make): Well, we would have to use a separate check: whether we can write to directories that don't have write privileges. It could be done. ___ Reply to this item at:

[bug #63852] Two test failure running the test suite as root

2023-02-28 Thread anonymous
Additional Item Attachment, bug #63852 (project make): File name: makeerror-4.4.1-x86_64-pc-linux-gnu-4quo.tar.gz Size:46 KB ___ Reply

[bug #15719] Test suite not reliable for parallel build support

2023-01-02 Thread Paul D. Smith
t; Closed ___ Follow-up Comment #10: A lot of work has been done on the test suite to try to ensure that the tests of parallelism work. A helper utility was added that allows a recipe to wait for some file to be created before exiting, which helps us ensure that things

[bug #63315] loadapi test / user-defined function reload SEGV failures

2022-11-13 Thread Paul D. Smith
Update of bug #63315 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #63315] loadapi test / user-defined function reload SEGV failures

2022-11-13 Thread Paul D. Smith
Update of bug #63315 (project make): Operating System:None => POSIX-Based Summary: Test failures with 4.4 on OpenBSD => loadapi test / user-defined function reload SEGV fa

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-13 Thread anonymous
Follow-up Comment #8, bug #63315 (project make): Me too, on OmniOS. Presumably Linux will map the shared object back into the same address as before, or has that just been luck? It's definitely not the case on all operating systems. Please consider changing the title of this bug so it's easier to

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-13 Thread anonymous
Follow-up Comment #7, bug #63315 (project make): I also hit this on illumos, and just reached the same conclusion - that the memory containing the function name in the hash table entry becomes unmapped when testapi.so is unloaded and loaded again. I'll apply the patch, thanks! __

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-06 Thread Paul D. Smith
Follow-up Comment #6, bug #63315 (project make): I'm not sure what the problem actually is here. It's something weird about the shell; it's doing something strange with SIGTERM. However I modified the helper app to be able to send TERM then replaced the test recipe "kill -T

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-06 Thread Paul D. Smith
Follow-up Comment #5, bug #63315 (project make): I was looking at it yesterday. Both the kill / cleanup tests (temp_stdin and the one in output-sync) are failing because they are showing the exit code, not the Terminated output. It's not a big problem because the temporary files are cleaned up p

[bug #62174] fix test functions/shell on aix.

2022-11-06 Thread Dmitry Goncharov
Follow-up Comment #5, bug #62174 (project make): I can confirm the current code works. Thank you. ___ Reply to this item at: ___ Message sent via Savann

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-05 Thread Brad Smith
Follow-up Comment #4, bug #63315 (project make): Thanks. What about the temp_stdin test? ___ Reply to this item at: <https://savannah.gnu.org/bugs/?63315> ___ Message sent via Sa

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-05 Thread Paul D. Smith
Follow-up Comment #3, bug #63315 (project make): Thank you for the assist Brad; I have found the problem and will fix it in the next release. FYI: diff --git a/src/function.c b/src/function.c index f0ef3434..893e583d 100644 --- a/src/function.c +++ b/src/function.c @@ -2801,7 +2801,7 @@ define_

Re: [bug #63315] Test failures with 4.4 on OpenBSD

2022-11-04 Thread Dmitry Goncharov
On Fri, Nov 4, 2022 at 3:51 PM Brad Smith wrote: > I can give you access to a system to test with. Brad, if you created an account for me, i'd be able to take care of this. Thank you regards, Dmitry

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-04 Thread Brad Smith
hich is cause coredumps, because we don't see this on the Linux or MacOS platform. > > If your makefiles don't use this feature it should be OK. > > For the output-sync error that's just an issue with the test framework; I will fix it. It's not a problem with GNU make

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-04 Thread Paul D. Smith
don't see this on the Linux or MacOS platform. If your makefiles don't use this feature it should be OK. For the output-sync error that's just an issue with the test framework; I will fix it. It's not a problem with GNU make itself.

[bug #63315] Test failures with 4.4 on OpenBSD

2022-11-03 Thread Brad Smith
URL: <https://savannah.gnu.org/bugs/?63315> Summary: Test failures with 4.4 on OpenBSD Project: make Submitter: brad0 Submitted: Fri 04 Nov 2022 03:06:58 AM UTC Severity: 3 - Normal Item Grou

[bug #62174] fix test functions/shell on aix.

2022-10-26 Thread Paul D. Smith
Follow-up Comment #4, bug #62174 (project make): Hm. the code tries to reset the locale to "C" before it detects any of this stuff. I guess maybe the method it uses (calling POSIX::setlocale()) isn't sufficient? OK I'll address this. I think the idea was that we didn't want to change the local

[bug #62174] fix test functions/shell on aix.

2022-10-25 Thread Dmitry Goncharov
Follow-up Comment #3, bug #62174 (project make): i guess this fell through the cracks. Paul, can you please have a look at sv62174_fix2.diff? ___ Reply to this item at: ___

[bug #52018] suggestion: test case for glob with dangling symlink

2022-10-19 Thread Bruno Haible
not have this test failure, that is, to exhibit the new behaviour of $(wildcard) even on older glibc systems. The way to do so would be to use the Gnulib module 'glob', which is documented to fix this problem: https://www.gnu.org/software/gnulib/manual/html_node/glob.html Currently GNU mak

[bug #52018] suggestion: test case for glob with dangling symlink

2022-10-19 Thread Martin Dorey
Follow-up Comment #6, bug #52018 (project make): If I've understood this correctly, then the upshot of the new test, https://git.savannah.gnu.org/cgit/make.git/commit/?id=f9ba22e02924e0a869a6e40ef4a70ee884d1ec46, is that we should expect a "failure", which is really just doc

[bug #63156] Preserve TMPDIR in test env.

2022-10-18 Thread Paul D. Smith
Update of bug #63156 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #63156] Preserve TMPDIR in test env.

2022-10-04 Thread Dmitry Goncharov
Additional Item Attachment, bug #63156 (project make): File name: sv63156.diff Size:1 KB ___ Reply to this item at:

[bug #63156] Preserve TMPDIR in test env.

2022-10-04 Thread Dmitry Goncharov
Follow-up Comment #1, bug #63156 (project make): Tests which are supposed to test that make removes temporary files succeed whether make removed the file or not. This happens because, test_driver.pl sets TMPDIR in makeENV after setting env for the test. Thus the test env uses the default TMPDIR

[bug #63156] Preserve TMPDIR in test env.

2022-10-04 Thread Dmitry Goncharov
URL: <https://savannah.gnu.org/bugs/?63156> Summary: Preserve TMPDIR in test env. Project: make Submitter: dgoncharov Submitted: Wed 05 Oct 2022 01:57:44 AM UTC Severity: 3 - Normal Item Grou

[bug #62496] Fix "7.3 Conditionals that Test Flags" in the manual,

2022-08-30 Thread Paul D. Smith
Update of bug #62496 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #62734] Have the test suite set ASAN env to ignore leaks.

2022-07-09 Thread Dmitry Goncharov
Additional Item Attachment, bug #62734 (project make): File name: sv62734.diff Size:0 KB ___ Reply to this item at:

[bug #62734] Have the test suite set ASAN env to ignore leaks.

2022-07-09 Thread Dmitry Goncharov
URL: <https://savannah.gnu.org/bugs/?62734> Summary: Have the test suite set ASAN env to ignore leaks. Project: make Submitter: dgoncharov Submitted: Sat 09 Jul 2022 06:57:40 PM UTC Severity: 3 -

[bug #62496] Fix "7.3 Conditionals that Test Flags" in the manual,

2022-05-20 Thread Dmitry Goncharov
Additional Item Attachment, bug #62496 (project make): File name: sv62496_test.diff Size:1 KB ___ Reply to this item at:

[bug #62496] Fix "7.3 Conditionals that Test Flags" in the manual,

2022-05-20 Thread Dmitry Goncharov
Additional Item Attachment, bug #62496 (project make): File name: sv62496_doc.diff Size:1 KB ___ Reply to this item at:

[bug #62496] Fix "7.3 Conditionals that Test Flags" in the manual,

2022-05-20 Thread Dmitry Goncharov
URL: <https://savannah.gnu.org/bugs/?62496> Summary: Fix "7.3 Conditionals that Test Flags" in the manual, Project: make Submitted by: dgoncharov Submitted on: Sat 21 May 2022 01:21:51 AM UTC Seve

Re: [bug #62173] Fix test features/archives.

2022-04-27 Thread Dmitry Goncharov
On Sun, Apr 24, 2022 at 2:48 PM Jeffrey Walton wrote: > Be sure to test the change on OpenBSD. In the past OpenBSD needed the > dash for options. I'm not sure if it is needed nowadays. The change that was mentioned added the dash. The current default ARFLAGS=-rv, which is also requir

[bug #62174] fix test functions/shell on aix.

2022-04-27 Thread Dmitry Goncharov
Follow-up Comment #2, bug #62174 (project make): Paul, the changes that were introduced in toplevel to set LANG=C do not have desired effect, because run_make_tests.pl sets $ERR_command_not_found before &toplevel is called. Since you didn't like removing LANG from environment, i attached another

[bug #62174] fix test functions/shell on aix.

2022-04-27 Thread Dmitry Goncharov
Additional Item Attachment, bug #62174 (project make): File name: sv62174_fix2.diff Size:0 KB ___ Reply to this item at:

[bug #62173] Fix test features/archives.

2022-04-27 Thread Dmitry Goncharov
Follow-up Comment #4, bug #62173 (project make): Paul, a typo was introduced, which causes multiple tests to fail. Please have a look at sv62173_fix_typo.diff. ___ Reply to this item at: _

[bug #62173] Fix test features/archives.

2022-04-27 Thread Dmitry Goncharov
Additional Item Attachment, bug #62173 (project make): File name: sv62173_fix_typo.diff Size:0 KB ___ Reply to this item at:

Re: [bug #62173] Fix test features/archives.

2022-04-24 Thread Jeffrey Walton
$arflags = "-Xany -rv"; > +} > > > That reason for the first part of the patch, specifically > ++++ > -my $arflags = 'rv'; > +my $arflags = '-rv' > > is the following > > The test has the following piece of code > > +++

[bug #62174] fix test functions/shell on aix.

2022-04-24 Thread Paul D. Smith
Update of bug #62174 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #62173] Fix test features/archives.

2022-04-24 Thread Paul D. Smith
Update of bug #62173 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #62172] Haver options/dash-l test exit greacefully, when getloadavg is not available

2022-04-24 Thread Paul D. Smith
Update of bug #62172 (project make): Status:None => Fixed Assigned to:None => psmith Open/Closed:Open => Closed Fixed Release:

[bug #62173] Fix test features/archives.

2022-03-13 Thread Dmitry Goncharov
y -my $arflags = 'rv'; +my $arflags = '-rv' is the following The test has the following piece of code $_ = `$ar U$arflags libxx.a a1.o $redir`; if ($? == 0) { $arflags = 'Urv'; $arvar = "$arvar ARFLAGS=$arflags"; } This piece of cod

[bug #62173] Fix test features/archives.

2022-03-12 Thread Eli Zaretskii
Follow-up Comment #1, bug #62173 (project make): It's eventually up to Paul, but I feel slightly uneasy with such fixes for the benefit of a system we barely support and that is not a free OS. E.g., I have quite a few of similar issues with the test suite on MS-Windows, but I never thou

[bug #62174] fix test functions/shell on aix.

2022-03-12 Thread Dmitry Goncharov
Additional Item Attachment, bug #62174 (project make): File name: test_functions_shell_fix_on_aix.diff Size:0 KB ___ Reply to this item at:

[bug #62174] fix test functions/shell on aix.

2022-03-12 Thread Dmitry Goncharov
URL: <https://savannah.gnu.org/bugs/?62174> Summary: fix test functions/shell on aix. Project: make Submitted by: dgoncharov Submitted on: Sat 12 Mar 2022 11:14:40 PM UTC Severity: 3 - Normal Item Grou

[bug #62173] Fix test features/archives.

2022-03-12 Thread Dmitry Goncharov
Additional Item Attachment, bug #62173 (project make): File name: test_features_archive_fix.diff Size:0 KB ___ Reply to this item at:

[bug #62173] Fix test features/archives.

2022-03-12 Thread Dmitry Goncharov
URL: <https://savannah.gnu.org/bugs/?62173> Summary: Fix test features/archives. Project: make Submitted by: dgoncharov Submitted on: Sat 12 Mar 2022 11:11:39 PM UTC Severity: 3 - Normal Item Grou

[bug #62172] Haver options/dash-l test exit greacefully, when getloadavg is not available

2022-03-12 Thread Dmitry Goncharov
Additional Item Attachment, bug #62172 (project make): File name: exit_grecefully_when_load_not_supported_fix.diff Size:0 KB ___ Reply

[bug #62172] Haver options/dash-l test exit greacefully, when getloadavg is not available

2022-03-12 Thread Dmitry Goncharov
URL: <https://savannah.gnu.org/bugs/?62172> Summary: Haver options/dash-l test exit greacefully, when getloadavg is not available Project: make Submitted by: dgoncharov Submitted on: Sat 12 Mar 2022 11:07:05

Re: make-4.3: wildcard test #9 fails

2020-04-05 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
> On Sun, 2020-04-05 at 16:19 +0200, Bruno Haible wrote: > > > > Building GNU make 4.3 on Ubuntu 16.04, produces one failing test: On filesystems which don't populate dirent::d_type (or on old glibc) test 7 also fails. I just asked gnulib mailing list to look at a patch. h

Re: make-4.3: wildcard test #9 fails

2020-04-05 Thread Paul Smith
On Sun, 2020-04-05 at 16:19 +0200, Bruno Haible wrote: > Hi Paul, > > > > Building GNU make 4.3 on Ubuntu 16.04, produces one failing test: > > > > This is because the glob() function in the older GNU libc has a bug > > related to handling symlinks correctly.

Re: make-4.3: wildcard test #9 fails

2020-04-05 Thread Bruno Haible
Hi Paul, > > Building GNU make 4.3 on Ubuntu 16.04, produces one failing test: > > This is because the glob() function in the older GNU libc has a bug > related to handling symlinks correctly. Gnulib provides a workaround against this bug in its 'glob' module [1]. But

Re: make-4.3: wildcard test #9 fails

2020-04-05 Thread Paul Smith
On Sun, 2020-04-05 at 15:33 +0200, Bruno Haible wrote: > Building GNU make 4.3 on Ubuntu 16.04, produces one failing test: This is because the glob() function in the older GNU libc has a bug related to handling symlinks correctly.

make-4.3: wildcard test #9 fails

2020-04-05 Thread Bruno Haible
Hi, Building GNU make 4.3 on Ubuntu 16.04, produces one failing test: $ ./configure --prefix=/arch/x86_64-linux-gnu/gnu-inst-make/4.3 $ make $ make check ... functions/wildcard .. FAILED (9/10 passed) ... vms/library

output-sync test can fail due to race condition

2020-01-23 Thread Christian Weisgerber
GNU make 4.3 I have been struggling with test suite failures on OpenBSD/arm64. Specifically, the output-sync test frequently shows failures. I have attached the work directory from such a test run. After closer examination, I think the failures are due to a race condition in the test itself

output-sync test mistake?

2020-01-23 Thread Christian Weisgerber
test... --- tests/scripts/features/output-sync.orig +++ tests/scripts/features/output-sync @@ -59,8 +59,8 @@ $set_bar_start = output_sync_set('bar_start'); $wait_foo = output_sync_wait('foo'); $wait_bar = output_sync_wait('bar'); -$wait_foo_start = output_sync_set(

Re: make-4.2.93 patch enhance error reporting from the test suite

2020-01-05 Thread Paul Smith
On Fri, 2020-01-03 at 22:19 -0500, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > This patch enhances error reporting from the test suite. Thanks I applied this.

Re: patch, new test features/exec.

2020-01-03 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Fri, Jan 3, 2020 at 12:10 PM Paul Smith wrote: > On Mon, 2019-10-14 at 22:21 -0400, Dmitry Goncharov via Bug reports and > discussion for GNU make wrote: > > This patch adds a new test features/exec. > > I added this test with a few adjustments. Thank you. i am glad to

make-4.2.93 patch enhance error reporting from the test suite

2020-01-03 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
Good morning. This patch enhances error reporting from the test suite. E.g. Clearing work... cannot unlink work/features/.nfs00c262d501ec: Device or resource busy cannot unlink work/features: Is a directory ./run_make_tests.pl: 697: Couldn't wipe out work: Is a directory re

Re: patch, new test features/exec.

2020-01-03 Thread Paul Smith
On Mon, 2019-10-14 at 22:21 -0400, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > This patch adds a new test features/exec. I added this test with a few adjustments.

[bug #43414] Perl test script bugs/enhancements

2019-12-26 Thread Paul D. Smith
Update of bug #43414 (project make): Item Group: Bug => Enhancement ___ Reply to this item at: ___ Messa

[bug #53152] Intermittent timeout running regression test features/output_sync

2019-12-26 Thread Paul D. Smith
Follow-up Comment #4, bug #53152 (project make): I see the issue; thanks for the explanation Michael. In some ways this is more of a test artifact than something likely to appear in a real makefile, although I think it really is a bug in make's logic. In a real makefile it's highl

patch, new test features/exec.

2019-10-14 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
Good morning. This patch adds a new test features/exec. features/exec tests that make can execute binaries as well as scripts with various shabangs and without a shebang and also with various values of SHELL=. The test demonstrates that the current (4.2.92) implementation fails to execute a shell

Please run your test suites

2019-09-30 Thread Earnestly via Bug-make
_tests.pl line 176. A quick look at the file seems to suggest `catfile' is called without appropriate namespacing, this simple diff corrects it and allows the test suite to complete without issue: diff --git a/tests/run_make_tests.pl b/tests/run_make_tests.pl index e2fddac..a7a 100644 --- a/te

Re: vpathplus test 2 patch

2019-09-22 Thread Paul Smith
On Mon, 2019-09-16 at 15:07 +0200, Andreas Schwab wrote: > > I didn't apply this change because I'm not exactly sure where I want to > > go with this yet. I'm not excited about tweaking the test suite based > > on the endianness of the underlying system but

Re: patch, test suite fails to run valgrind

2019-09-22 Thread Paul Smith
On Sat, 2019-09-21 at 21:21 -0400, Dmitry Goncharov wrote: > On Sat, Sep 21, 2019 at 04:54:59PM -0400, Paul Smith wrote: > > I pushed a different fix for this issue. Thanks for noticing! > Thank you. > Do you intentionally avoid $! in the "Cannot execute" error message? No, I just didn't change t

Re: patch, test suite fails to run valgrind

2019-09-21 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Sat, Sep 21, 2019 at 04:54:59PM -0400, Paul Smith wrote: > I pushed a different fix for this issue. Thanks for noticing! Thank you. Do you intentionally avoid $! in the "Cannot execute" error message? regards, Dmitry > ___ Bug-make mailing list Bu

Re: patch, test suite fails to run valgrind

2019-09-21 Thread Paul Smith
On Wed, 2019-09-18 at 21:38 -0400, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > The test suite fails to run valgrind with an error message like the following. I pushed a different fix for this issue. Thanks for notic

patch, test suite fails to run valgrind

2019-09-18 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
Good morning. The test suite fails to run valgrind with an error message like the following. $ ./run_make_tests -memcheck -make_path ../l64/make features/archives ... ok (12 passed) features/comments ... *** Test died

Re: vpathplus test 2 patch

2019-09-16 Thread Andreas Schwab
on big vs little >> > > > endian. >> > > >> > > Should this be considered as a bug? >> > >> > I don't think the order or removal of intermediate files was >> > specified. >> >> The testsuite obviously is depending on it

Re: vpathplus test 2 patch

2019-09-16 Thread Paul Smith
> > > Should this be considered as a bug? > > > > I don't think the order or removal of intermediate files was > > specified. > > The testsuite obviously is depending on it. The test suite simply matches output strings, it's not very intelligent about stuf

Re: patch to fix grouped_targets test 1

2019-09-14 Thread Paul Smith
On Tue, 2019-09-10 at 20:36 -0400, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > echo -n is not portable. > Certain implementations of echo everything, including -n. > This makes test 1 of grouped_targets fail. This was already fixed by a patch from Paul Eggert

Re: vpathplus test 2 patch

2019-09-12 Thread Andreas Schwab
On Sep 11 2019, Dmitry Goncharov wrote: > On Wed, Sep 11, 2019 at 2:51 AM Andreas Schwab wrote: >> >> > The new hashing mechanism hashes differently on big vs little endian. >> >> Should this be considered as a bug? > > I don't think the order or removal of intermediate files was > specified. T

Re: vpathplus test 2 patch

2019-09-11 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
On Wed, Sep 11, 2019 at 2:51 AM Andreas Schwab wrote: > > > The new hashing mechanism hashes differently on big vs little endian. > > Should this be considered as a bug? I don't think the order or removal of intermediate files was specified. Do you have a specific use case in mind, Andreas? rega

Re: vpathplus test 2 patch

2019-09-10 Thread Andreas Schwab
On Sep 10 2019, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > The new hashing mechanism hashes differently on big vs little endian. Should this be considered as a bug? Andreas. -- Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4B

vpathplus test 2 patch

2019-09-10 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
The new hashing mechanism hashes differently on big vs little endian. This makes vpathplus test 2 fail, because the order of intermediate files inter.b and inter.c is now dependent on endiannes. regards, Dmitry diff --git a/tests/scripts/features/vpathplus b/tests/scripts/features/vpathplus

patch to fix grouped_targets test 1

2019-09-10 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
Good morning. echo -n is not portable. Certain implementations of echo everything, including -n. This makes test 1 of grouped_targets fail. regards, Dmitry diff --git a/tests/scripts/features/grouped_targets b/tests/scripts/features/grouped_targets index ef9366b..4d2c9d2 100644 --- a/tests

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Eli Zaretskii
> From: Paul Smith > Cc: bug-make@gnu.org > Date: Tue, 10 Sep 2019 12:35:18 -0400 > > > Btw, I see you added support for dirent.d_type for dirent functions > > emulation when compiling with MSVC, but I don't think Make uses this > > anywhere, except when building with glibc. In particular, the >

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Paul Smith
On Tue, 2019-09-10 at 19:17 +0300, Eli Zaretskii wrote: > Btw, I see you added support for dirent.d_type for dirent functions > emulation when compiling with MSVC, but I don't think Make uses this > anywhere, except when building with glibc. In particular, the > HAVE_STRUCT_DIRENT_D_TYPE macro doe

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Eli Zaretskii
> From: Paul Smith > Cc: dgoncha...@users.sf.net, bug-make@gnu.org > Date: Tue, 10 Sep 2019 11:47:35 -0400 > > On Tue, 2019-09-10 at 17:47 +0300, Eli Zaretskii wrote: > > > From: Paul Smith > > > Date: Tue, 10 Sep 2019 08:36:24 -0400 > > > > > > I plan to make a new release candidate this week.

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Paul Smith
On Tue, 2019-09-10 at 17:47 +0300, Eli Zaretskii wrote: > > From: Paul Smith > > Date: Tue, 10 Sep 2019 08:36:24 -0400 > > > > I plan to make a new release candidate this week. > > Did you have a chance to review the patch I proposed in > https://lists.gnu.org/archive/html/bug-make/2019-08/msg00

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Eli Zaretskii
> From: Paul Smith > Date: Tue, 10 Sep 2019 08:36:24 -0400 > > I plan to make a new release candidate this week. Did you have a chance to review the patch I proposed in https://lists.gnu.org/archive/html/bug-make/2019-08/msg00106.html? I'd like to install it. Also, regarding SV 56449: are you o

Re: patch to fix features/archives test 10 on sunos

2019-09-10 Thread Paul Smith
On Mon, 2019-09-09 at 22:30 -0400, Dmitry Goncharov via Bug reports and discussion for GNU make wrote: > ar add output is system dependent. Thanks Dmitry; I had already made basically that same change. See the latest Git master (pushed this morning). I plan to make a new release candidate this w

patch to fix features/archives test 10 on sunos

2019-09-09 Thread Dmitry Goncharov via Bug reports and discussion for GNU make
Good morning. ar add output is system dependent. This makes features/archives test 10 fail on sunos. This patch uses the output of `ar rv` rather than a hardcoded string. linux $ ar rv libxx.a 1234567890123456b a - 1234567890123456b sunos $ ar rv libxx.a 1234567890123456b a - 1234567890123456b

[PATCH] Port grouped_targets test to Solaris 10

2019-08-27 Thread Paul Eggert
s/features/grouped_targets index ef9366b..615e962 100644 --- a/tests/scripts/features/grouped_targets +++ b/tests/scripts/features/grouped_targets @@ -9,7 +9,7 @@ $details = "Here we test for requirements like\n" run_make_test(q{ .PHONY: all &:; -all: ;@echo -n +all: ;@printf '

[bug #53152] Intermittent timeout running regression test features/output_sync

2019-07-07 Thread Michael Olbrich
Follow-up Comment #3, bug #53152 (project make): I think the problem is the outer loop in update_goal_chain(): - All goals are handle once per loop iteration. - At the beginning of each iteration at least on child is reaped (if any exist) What happens is this: First iteration: - job for 'bar' is

[bug #55944] make-4.2 arm64 w10 test

2019-05-12 Thread Paul D. Smith
Update of bug #55944 (project make): Status:None => Wont Fix Open/Closed:Open => Closed ___ Follow-up Comment #1: Sorry, but there's no

  1   2   3   >