Re: 4.3.90 release candidate segfaults on linux and solaris

2022-09-24 Thread Martin Dorey
I have a 32 bit Debian Squeeze (so 2011 era, with gcc-4.4 - too early for asan - and libc 2.11, so two Debian releases earlier than Denis’s) chroot lying around. Unsurprisingly, his reproducer crashes for me too, configured with no options and make run with no arguments. gdb’s reporting line 1

Re: 4.3.90 release candidate segfaults on linux and solaris

2022-09-24 Thread Paul Smith
On Sat, 2022-09-24 at 13:06 -0400, Paul Smith wrote: > > The crashes in solaris and linux are so similar, and go away also > > so similarly, that i would primarily think about size of types. > > Under cygwin and MacOS all sizes (pointers, long int, size_t, > > SIZE_MAX, time_t) are 8, while under (

Re: GNU make 4.3.90 release candidate available

2022-09-24 Thread Paul Smith
On Sat, 2022-09-24 at 16:41 -0400, Paul Smith wrote: > makeint.h already has HAVE_MAKEINT_H Doh, I meant HAVE_INTTYPES_H of course.

Re: GNU make 4.3.90 release candidate available

2022-09-24 Thread Paul Smith
On Sat, 2022-09-24 at 21:09 +0300, Eli Zaretskii wrote: > MinGW does have inttypes.h, if you want to use PRId64 or somesuch, > and > if the other supported platforms have that. > > I'm fine with using our own definition for PRId64, if that's what you > prefer.  On makeint.h, I presume? makeint.h

[bug #63100] Crash in a loadable plugin

2022-09-24 Thread Dmitry Goncharov
Follow-up Comment #1, bug #63100 (project make): When make unloads and then loads a shared object make supplies an uninitialized floc to the plugin setup routine. $ cat makefile load hello.so all:; : hello.so: force; : force:; .PHONY: force $ cat hello.c #include #include int plugin_is_GP

[bug #63100] Crash in a loadable plugin

2022-09-24 Thread Dmitry Goncharov
Additional Item Attachment, bug #63100 (project make): File name: sv63100_fix.diff Size:0 KB File name: sv63100_test.diff Size:1 KB

[bug #63100] Crash in a loadable plugin

2022-09-24 Thread Dmitry Goncharov
URL: Summary: Crash in a loadable plugin Project: make Submitter: dgoncharov Submitted: Sat 24 Sep 2022 08:30:58 PM UTC Severity: 3 - Normal Item Group: Bug

Re: GNU make 4.3.90 release candidate available

2022-09-24 Thread Eli Zaretskii
> From: Paul Smith > Cc: bug-make@gnu.org > Date: Sat, 24 Sep 2022 13:10:00 -0400 > > > Here are the proposed patches for the above 2 warnings.  Paul, if you > > agree with them, I will install them in the repository. > > These changes look good to me, thanks! Thanks, installed.

Re: GNU make 4.3.90 release candidate available

2022-09-24 Thread Eli Zaretskii
> From: Paul Smith > Cc: bug-make@gnu.org > Date: Sat, 24 Sep 2022 13:45:57 -0400 > > On Wed, 2022-09-21 at 06:18 +0100, Sam James wrote: > > Can I suggest forwarding to the platform-testers@ mailing list as > > well? > > I've never heard of this; is it @gnu.org? Yes, platform-test...@gnu.org.

Re: GNU make 4.3.90 release candidate available

2022-09-24 Thread Eli Zaretskii
> From: Paul Smith > Cc: bug-make@gnu.org > Date: Sat, 24 Sep 2022 13:42:39 -0400 > > On Sat, 2022-09-24 at 14:17 +0300, Eli Zaretskii wrote: > > Here are the proposed patches: > > > > --- src/function.c~02022-09-18 22:06:17.0 +0300 > > +++ src/function.c  2022-09-24 13:30:01.740

Re: GNU make 4.3.90 release candidate available

2022-09-24 Thread Paul Smith
On Wed, 2022-09-21 at 06:18 +0100, Sam James wrote: > Can I suggest forwarding to the platform-testers@ mailing list as > well? I've never heard of this; is it @gnu.org? Or somewhere else? A full email address would be useful and also if you have any information on this (a website or whatever) t

Re: GNU make 4.3.90 release candidate available

2022-09-24 Thread Paul Smith
On Sat, 2022-09-24 at 14:17 +0300, Eli Zaretskii wrote: > Here are the proposed patches: > > --- src/function.c~02022-09-18 22:06:17.0 +0300 > +++ src/function.c  2022-09-24 13:30:01.740875000 +0300 > @@ -823,6 +823,15 @@ func_wordlist (char *o, char **argv, con >    stop = parse_n

Re: GNU make 4.3.90 release candidate available

2022-09-24 Thread Paul Smith
On Sat, 2022-09-24 at 14:09 +0300, Eli Zaretskii wrote: > I've built this with mingw.org's MinGW for native MS-Windows.  I > found several issues during the build, some of them specific to > Windows, others more general.  (I didn't yet run the test suite, I > intend to do that next.) > > Here are

Re: 4.3.90 release candidate segfaults on linux and solaris

2022-09-24 Thread Paul Smith
On Sat, 2022-09-24 at 18:23 +0200, Denis Excoffier wrote: > The segfault also occurs without ‘env -i’. Thanks for helping me avoid that red herring. > The crashes in solaris and linux are so similar, and go away also so > similarly, that i would primarily think about size of types. Under > cygwin

Re: 4.3.90 release candidate segfaults on linux and solaris

2022-09-24 Thread Denis Excoffier
> On 2022-09-24 17:19, Paul Smith wrote: > > On Sat, 2022-09-24 at 09:36 +0200, Denis Excoffier wrote: >> In my specific configuration (under linux, with --disable-nls, >> --disable-load, without using -j, using 'env -i make -d -n'), a >> segfault always occurs around line 118 of src/expand.c: >

Re: 4.3.90 release candidate segfaults on linux and solaris

2022-09-24 Thread Paul Smith
On Sat, 2022-09-24 at 09:36 +0200, Denis Excoffier wrote: > In my specific configuration (under linux, with --disable-nls, > --disable-load, without using -j, using 'env -i make -d -n'), a > segfault always occurs around line 118 of src/expand.c: > > My linux is old (2.6.32), The kernel version i

Re: GNU make 4.3.90 release candidate available

2022-09-24 Thread Eli Zaretskii
I've built this with mingw.org's MinGW for native MS-Windows. I found several issues during the build, some of them specific to Windows, others more general. Below are the build-time issues that are specific to MS-Windows, and the proposed patches. Paul, I'll wait for your okay before installing

Re: GNU make 4.3.90 release candidate available

2022-09-24 Thread Eli Zaretskii
I've built this with mingw.org's MinGW for native MS-Windows. I found several issues during the build, some of them specific to Windows, others more general. (I didn't yet run the test suite, I intend to do that next.) Here are the build-time issues that aren't specific to MS-Windows: src/

4.3.90 release candidate segfaults on linux and solaris

2022-09-24 Thread Denis Excoffier
Hello, At the beginning, i found a segfault in the source code of autoconf-2.71. I reduced the case and the current test Makefile is as follows: % cat Makefile export PATH = $(shell echo "`pwd`/tests:$$PATH") foo = $(shell echo yes) all: echo $(foo) % In my specific configuration (unde