On Sat, 2022-09-24 at 14:09 +0300, Eli Zaretskii wrote: > I've built this with mingw.org's MinGW for native MS-Windows. I > found several issues during the build, some of them specific to > Windows, others more general. (I didn't yet run the test suite, I > intend to do that next.) > > Here are the build-time issues that aren't specific to MS-Windows: > > src/getopt.c: In function '_getopt_internal': > src/getopt.c:679:8: warning: suggest explicit braces to avoid > ambiguous 'else' [-Wdangling-else] > 679 | if (opterr) > | ^ > > (This is not new to this release, I saw the same in Make 4.3.) I > ignored this one.
Agreed. I need to update to the newer getopt library from gnulib (along with the newer glob library) but this is non-trivial for GNU make so I will probably wait until after this release. > Here are the proposed patches for the above 2 warnings. Paul, if you > agree with them, I will install them in the repository. These changes look good to me, thanks!
