Re: Yet another updated entropy patch ...

2007-08-28 Thread Samuel Thibault
Michael Casadevall, le Tue 28 Aug 2007 07:35:32 -0400, a écrit : > Index: device/blkio.c > @@ -149,6 +151,10 @@ > do { > prev = next; > next = prev->io_next; > +#ifdef MACH_ENTROPY > + /* Let's grab the cylinder numbers for entropy. */ > + entropy_putdata

Yet another updated entropy patch ...

2007-08-28 Thread Michael Casadevall
Sorry for my absence, quite a bit happened to me in real life, but I'm back with another entropy patch (hopefully ready to finally see a version make it into CVS). This patch properly implements quality control, and quality improvement, as well as cleaned up source. The driver itself can be used wi

Updated Entropy Patch (with quality control)

2007-08-08 Thread Michael Casadevall
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 After a caffine driven inspired hacking fest I managed to add quality control to the driver, and resolved the GCS issues, as well as the ones Marcus noted. I also cleaned up the code, and tweaked it some more. Any comments would be appericated. Mi

Re: Yet another updated entropy patch

2007-08-01 Thread olafBuddenhagen
Hi, On Mon, Jul 23, 2007 at 08:39:55AM +0200, Marcus Brinkmann wrote: > It could be different if we had a good single entropy source in every > computer. Unfortunately, entropy devices are a rarity. That's not true. Intel introduced hardware random number generators in their chipsets like ten y

Re: Yet another updated entropy patch

2007-07-27 Thread Thomas Schwinge
Hello! On Mon, Jul 23, 2007 at 08:39:55AM +0200, Marcus Brinkmann wrote: > [...] Thanks for these details! Michael Casadevall: you know what to do? Regards, Thomas signature.asc Description: Digital signature ___ Bug-hurd mailing list Bug-hurd@gn

Re: Yet another updated entropy patch

2007-07-22 Thread Marcus Brinkmann
At Fri, 20 Jul 2007 18:53:05 +0200, Thomas Schwinge <[EMAIL PROTECTED]> wrote: > On Thu, Jul 19, 2007 at 01:52:39AM +0200, Marcus Brinkmann wrote: > > At Thu, 19 Jul 2007 01:40:12 +0200, > > Thomas Schwinge <[EMAIL PROTECTED]> wrote: > > > What do you perceive as the benefit of having the entropy

Re: Yet another updated entropy patch

2007-07-20 Thread olafBuddenhagen
Hi, On Thu, Jul 19, 2007 at 01:52:39AM +0200, Marcus Brinkmann wrote: > What do you perceive as the benefit of having the entropy mixing > function outside of the device framework in its own user space server? The very same reasons why we bother with this microkernel stuff at all: - Reducing me

Re: Yet another updated entropy patch

2007-07-20 Thread Thomas Schwinge
Hello! On Thu, Jul 19, 2007 at 01:52:39AM +0200, Marcus Brinkmann wrote: > At Thu, 19 Jul 2007 01:40:12 +0200, > Thomas Schwinge <[EMAIL PROTECTED]> wrote: > > Can't we come up with something better than putting the mixing machinery > > into the kernel? > > I am not arguing for the mixing to happ

Re: Yet another updated entropy patch

2007-07-18 Thread Marcus Brinkmann
At Thu, 19 Jul 2007 01:40:12 +0200, Thomas Schwinge <[EMAIL PROTECTED]> wrote: > Uhm, Marcus, I don't really feel like discussing such nuisance, but I'd > say that as soon as you're putting in new-line breaks (which the GCS and > our own sanity mandates) you're as well editing in two dimensions, i

Re: Yet another updated entropy patch

2007-07-18 Thread Thomas Schwinge
Hello! On Sun, Jul 15, 2007 at 10:53:02PM +0200, Marcus Brinkmann wrote: > At Fri, 13 Jul 2007 22:50:00 -0400, > Michael Casadevall <[EMAIL PROTECTED]> wrote: > > On Jul 13, 2007, at 4:30 AM, Marcus Brinkmann wrote: > > /* Sune Kirkeby's entropy patch (which was a port of the > > * linux entropy

Re: Yet another updated entropy patch

2007-07-15 Thread Marcus Brinkmann
At Fri, 13 Jul 2007 22:50:00 -0400, Michael Casadevall <[EMAIL PROTECTED]> wrote: > > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > (this is a response to both emails about said patch) > > Marcus: I don't think I've ever been nitpicked that badly in my > life. Congratulations! I guess

Re: Yet another updated entropy patch

2007-07-13 Thread Michael Casadevall
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 (this is a response to both emails about said patch) Marcus: I don't think I've ever been nitpicked that badly in my life. Congratulations! On Jul 13, 2007, at 4:30 AM, Marcus Brinkmann wrote: Hi, some comments, not in order of importance. I

Re: Yet another updated entropy patch

2007-07-13 Thread olafBuddenhagen
Hi, On Fri, Jul 13, 2007 at 01:04:01AM -0400, Michael Casadevall wrote: > + void entropy_putchar(int c) { [...] > + if (entropy_write_offset == ENTROPYBUFSIZE) { > + entropy_write_offset = 0; > + } > + > + if (entropy_write_offset == ENTROPYBUFSIZE) { > + entropy_write_offset = 0; >

Re: Yet another updated entropy patch

2007-07-13 Thread Marcus Brinkmann
Hi, some comments, not in order of importance. > It also has the patch in the proper format: Well, I prefer diff -rup, but what the heck. > AM_CONDITIONAL([enable_kmsg], [false]) I was going to suggest uppercase for automake conditionals, but you can refer to prior art, so nevermind :) >

Yet another updated entropy patch

2007-07-12 Thread Michael Casadevall
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This includes a little more sanity checking, and it also fixes the ring code bug which antrik explained to me in detail. It also has the patch in the proper format: ? INSTALL ? Makefile.in ? aclocal.m4 ? autom4te.cache ? build ? build-aux ? conf

Updated Entropy Patch (now with Disk I/O)

2007-07-10 Thread Michael Casadevall
After bit bashing, I managed to get the entropy driver working properly with I/O sources without destroying I/O performance. I also cleaned up my code somewhat. If you want to use the entropy driver now, you can use streamio (I'm working on a random translator at the moment) with settrans -

Updated Entropy Patch

2007-07-10 Thread Michael Casadevall
entropy.c Description: Binary data entropy.diff Description: Binary data entropy.h Description: Binary data This is an updated version of my original entropy patch (both entropy files go into gnumach/device). It exposes a new interface for adding entropy, entropy_putdata, removes the twis