Re: GSoC: PATH_MAX

2011-04-08 Thread Samuel Thibault
Patrik Olsson, le Fri 08 Apr 2011 12:39:25 +0200, a écrit : > Submit where? Upstream or to Debian Alioth or ...? Good question. Submitting to the Debian bugtracker only would make maintainers have to forward upstream. Forwarding upstream is more perenial, but only upstream would make the patch ap

Re: GSoC: PATH_MAX

2011-04-08 Thread Samuel Thibault
olafbuddenha...@gmx.net, le Fri 08 Apr 2011 19:26:27 +0200, a écrit : > On Fri, Apr 08, 2011 at 01:24:25AM +0200, Samuel Thibault wrote: > > > In that particular case, libsepol, the package is actually expected to > > be used on Linux only, so it's probably fine. Now, since it's actually > > Linux

Re: GSoC: PATH_MAX

2011-04-08 Thread olafBuddenhagen
Hi, On Fri, Apr 08, 2011 at 12:31:57PM +0200, Patrik Olsson wrote: > On 07/04/11 21:42, olafbuddenha...@gmx.net wrote: > > A general remark: not all plattforms have asprintf(). Depending on > > how portable the packages in question are, you might need to add > > configure-time checks and/or compi

Re: GSoC: PATH_MAX

2011-04-08 Thread olafBuddenhagen
Hallo, On Fri, Apr 08, 2011 at 01:24:25AM +0200, Samuel Thibault wrote: > In that particular case, libsepol, the package is actually expected to > be used on Linux only, so it's probably fine. Now, since it's actually > Linux-only, it's probably also not really useful to port this one... Well, i

Re: GSoC: PATH_MAX

2011-04-08 Thread olafBuddenhagen
Hi, On Thu, Apr 07, 2011 at 11:40:56PM +0200, Emilio Pozuelo Monfort wrote: > I thought free(NULL) wasn't safe and led to crashes, but you're right > according to free(3). It's amazing how many programmers are not aware of that :-) It's one of the most frequent things I tend to point out in patc

Re: GSoC: PATH_MAX

2011-04-08 Thread Patrik Olsson
On 08/04/11 01:24, Samuel Thibault wrote: > Could you rather look at the top of this page? > > http://people.debian.org/~sthibault/graph-total-top.txt > > This is what is mostly needed. A lot of them will however not be > trivial so you'll have to sort it out a bit by checking what kind of > fail

Re: GSoC: PATH_MAX

2011-04-08 Thread Patrik Olsson
Hello, On 07/04/11 21:42, olafbuddenha...@gmx.net wrote: > > A general remark: not all plattforms have asprintf(). Depending on how > portable the packages in question are, you might need to add > configure-time checks and/or compile-time conditionals. > I am aware of that, but from what I coul

Re: GSoC: PATH_MAX

2011-04-07 Thread Samuel Thibault
Hello, Patrik Olsson, le Wed 06 Apr 2011 19:02:14 +0200, a écrit : > As a preparation exercise for GSoC, I have fixed the PATH_MAX issue in > three Debian packages: nekobee, whysynth and libsepol. There is no real > reason I picked these packages, they were just first in the list here: > > https:

Re: GSoC: PATH_MAX

2011-04-07 Thread Emilio Pozuelo Monfort
On 07/04/11 21:42, olafbuddenha...@gmx.net wrote: > I don't know how g_free() behaves -- but if it's the same as normal > free(), you don't need the conditional: free(NULL) is a no-op by > definition. g_free is null-safe too. I thought free(NULL) wasn't safe and led to crashes, but you're right ac

Re: GSoC: PATH_MAX

2011-04-07 Thread olafBuddenhagen
Hi, On Wed, Apr 06, 2011 at 07:02:14PM +0200, Patrik Olsson wrote: > As a preparation exercise for GSoC, I have fixed the PATH_MAX issue in > three Debian packages: nekobee, whysynth and libsepol. Great. From what I can see, these are all pretty simple cases -- but it's certainly a good start :-

GSoC: PATH_MAX

2011-04-06 Thread Patrik Olsson
Hello! As a preparation exercise for GSoC, I have fixed the PATH_MAX issue in three Debian packages: nekobee, whysynth and libsepol. There is no real reason I picked these packages, they were just first in the list here: https://buildd.debian.org/stats/?arch=hurd-i386&state=Failed Note that they